Fix nested repeats with track-by.

nkovacs · nkovacs · commit 676669cecd94 · 2015-04-15T17:21:09.000+02:00
When the parent vm is reused, newly created children will inherit the _reused property, and they won't be inserted into the dom. Fixes vuejs#782
diff --git a/src/directives/repeat.js b/src/directives/repeat.js
@@ -252,6 +252,7 @@ module.exports = {
       } else { // new instance
         vm = this.build(obj, i, true)
         vm._new = true
+        vm._reused = false
       }
       vms[i] = vm
       // insert if this is first run
diff --git a/test/unit/specs/directives/repeat_spec.js b/test/unit/specs/directives/repeat_spec.js
@@ -622,6 +622,60 @@ if (_.inBrowser) {
       })
     })
 
+    it('nested track by', function (done) {
+      assertTrackBy('<div v-repeat="list" track-by="id">{{msg}}<div v-repeat="list" track-by="id">{{msg}}</div></div>', function () {
+        assertTrackBy('<div v-transition v-repeat="list" track-by="id">{{msg}}<div v-transition v-repeat="list" track-by="id">{{msg}}</div></div>', done)
+      })
+
+      function assertTrackBy(template, next) {
+        var vm = new Vue({
+          el: el,
+          data: {
+            list: [
+              { id: 1, msg: 'hi', list: [
+                { id: 1, msg: 'hi foo' }
+              ] },
+              { id: 2, msg: 'ha', list: [] },
+              { id: 3, msg: 'ho', list: [] }
+            ]
+          },
+          template: template
+        })
+        assertMarkup()
+
+        var oldVms = vm._children.slice()
+
+        vm.list = [
+          { id: 1, msg: 'wa', list: [
+            { id: 1, msg: 'hi foo' },
+            { id: 2, msg: 'hi bar' }
+          ] },
+          { id: 2, msg: 'wo', list: [] }
+        ]
+
+        _.nextTick(function () {
+          assertMarkup()
+          // should reuse old vms!
+          var i = 2
+          while (i--) {
+            expect(vm._children[i]).toBe(oldVms[i])
+          }
+          expect(vm._children[0]._children[0]).toBe(oldVms[0]._children[0])
+          next()
+        })
+
+        function assertMarkup () {
+          var markup = vm.list.map(function (item) {
+            var sublist = item.list.map(function (item) {
+              return '<div>' + item.msg + '</div>'
+            }).join('') + '<!--v-repeat-->'
+            return '<div>' + item.msg + sublist + '</div>'
+          }).join('') + '<!--v-repeat-->'
+          expect(el.innerHTML).toBe(markup)
+        }
+      }
+    })
+
   })
 }
 

Original file line number	Diff line number	Diff line change
`@@ -252,6 +252,7 @@ module.exports = {`
`252`	`252`	`} else { // new instance`
`253`	`253`	`vm = this.build(obj, i, true)`
`254`	`254`	`vm._new = true`
	`255`	`+ vm._reused = false`
`255`	`256`	`}`
`256`	`257`	`vms[i] = vm`
`257`	`258`	`// insert if this is first run`