More informative warning message for comp name (vuejs#4429)

phanan · yyx990803 · commit 962b778e1098 · 2016-12-09T12:51:13.000-05:00
This commit adds a more informative warning message for invalid component names. Also fixes a typo. Closes vuejs#4428.
diff --git a/src/core/global-api/extend.js b/src/core/global-api/extend.js
@@ -28,7 +28,8 @@ export function initExtend (Vue: GlobalAPI) {
       if (!/^[a-zA-Z][\w-]*$/.test(name)) {
         warn(
           'Invalid component name: "' + name + '". Component names ' +
-          'can only contain alphanumeric characaters and the hyphen.'
+          'can only contain alphanumeric characters and the hyphen, ' +
+          'and must start with a letter.'
         )
       }
     }
diff --git a/test/unit/features/options/name.spec.js b/test/unit/features/options/name.spec.js
@@ -15,7 +15,16 @@ describe('Options name', () => {
     })
 
     /* eslint-disable */
-    expect(`Invalid component name: "Hyper*Vue". Component names can only contain alphanumeric characaters and the hyphen.`)
+    expect(`Invalid component name: "Hyper*Vue". Component names can only contain alphanumeric characters and the hyphen, and must start with a letter.`)
+      .toHaveBeenWarned()
+    /* eslint-enable */
+
+    Vue.extend({
+      name: '2Cool2BValid'
+    })
+
+    /* eslint-disable */
+    expect(`Invalid component name: "2Cool2BValid". Component names can only contain alphanumeric characters and the hyphen, and must start with a letter.`)
       .toHaveBeenWarned()
     /* eslint-enable */
   })

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ export function initExtend (Vue: GlobalAPI) {`
`28`	`28`	`if (!/^[a-zA-Z][\w-]*$/.test(name)) {`
`29`	`29`	`warn(`
`30`	`30`	`'Invalid component name: "' + name + '". Component names ' +`
`31`		`- 'can only contain alphanumeric characaters and the hyphen.'`
	`31`	`+ 'can only contain alphanumeric characters and the hyphen, ' +`
	`32`	`+ 'and must start with a letter.'`
`32`	`33`	`)`
`33`	`34`	`}`
`34`	`35`	`}`