Use genAssignmentCode in chehckbox model web compiler (vuejs#5402)

posva · yyx990803 · commit b997af0c012d · 2017-04-10T12:24:08.000+08:00
Fix vuejs#5398
diff --git a/src/platforms/web/compiler/directives/model.js b/src/platforms/web/compiler/directives/model.js
@@ -91,7 +91,7 @@ function genCheckboxModel (
           '$$i=_i($$a,$$v);' +
       `if($$c){$$i<0&&(${value}=$$a.concat($$v))}` +
       `else{$$i>-1&&(${value}=$$a.slice(0,$$i).concat($$a.slice($$i+1)))}` +
-    `}else{${value}=$$c}`,
+    `}else{${genAssignmentCode(value, '$$c')}}`,
     null, true
   )
 }
diff --git a/test/unit/features/directives/model-checkbox.spec.js b/test/unit/features/directives/model-checkbox.spec.js
@@ -256,4 +256,29 @@ describe('Directive v-model checkbox', () => {
       expect(vm.$el.checked).toBe(true)
     }).then(done)
   })
+
+  it('triggers a watcher when binding to an array value in a checkbox', done => {
+    const vm = new Vue({
+      data: {
+        test: {
+          thing: false,
+          arr: [true]
+        }
+      },
+      template: `
+        <div>
+          <input type="checkbox" v-model="test.arr[0]">
+          <span>{{ test.arr[0] }}</span>
+        </div>
+      `
+    }).$mount()
+    document.body.appendChild(vm.$el)
+    expect(vm.$el.children[0].checked).toBe(true)
+    expect(vm.$el.children[1].textContent).toBe('true')
+    vm.$el.children[0].click()
+    expect(vm.$el.children[0].checked).toBe(false)
+    waitForUpdate(() => {
+      expect(vm.$el.children[1].textContent).toBe('false')
+    }).then(done)
+  })
 })

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ function genCheckboxModel (`
`91`	`91`	`'$$i=_i($$a,$$v);' +`
`92`	`92`	`if($$c){$$i<0&&(${value}=$$a.concat($$v))}` +
`93`	`93`	`else{$$i>-1&&(${value}=$$a.slice(0,$$i).concat($$a.slice($$i+1)))}` +
`94`		- `}else{${value}=$$c}`,
	`94`	+ `}else{${genAssignmentCode(value, '$$c')}}`,
`95`	`95`	`null, true`
`96`	`96`	`)`
`97`	`97`	`}`