remove unnecessary slice in SSR renderStyle (small perf gain)

yyx990803 · yyx990803 · commit c9fbcaf5919d · 2017-01-19T23:41:37.000-05:00
diff --git a/src/platforms/web/server/modules/style.js b/src/platforms/web/server/modules/style.js
@@ -8,7 +8,7 @@ function genStyleText (vnode: VNode): string {
   for (const key in style) {
     styleText += `${hyphenate(key)}:${style[key]};`
   }
-  return styleText.slice(0, -1)
+  return styleText
 }
 
 export default function renderStyle (vnode: VNodeWithData): ?string {
diff --git a/test/ssr/ssr-string.spec.js b/test/ssr/ssr-string.spec.js
@@ -102,7 +102,7 @@ describe('SSR: renderToString', () => {
       }
     }, result => {
       expect(result).toContain(
-        '<div server-rendered="true" style="background-color:black;font-size:14px;color:red"></div>'
+        '<div server-rendered="true" style="background-color:black;font-size:14px;color:red;"></div>'
       )
       done()
     })
@@ -116,7 +116,7 @@ describe('SSR: renderToString', () => {
       }
     }, result => {
       expect(result).toContain(
-        '<div server-rendered="true" style="color:red"></div>'
+        '<div server-rendered="true" style="color:red;"></div>'
       )
       done()
     })
@@ -135,7 +135,7 @@ describe('SSR: renderToString', () => {
       }
     }, result => {
       expect(result).toContain(
-        '<section server-rendered="true"><div style="color:red"></div></section>'
+        '<section server-rendered="true"><div style="color:red;"></div></section>'
       )
       done()
     })
@@ -159,7 +159,7 @@ describe('SSR: renderToString', () => {
       }
     }, result => {
       expect(result).toContain(
-        '<div server-rendered="true" style="text-align:left;font-size:520rem;color:red"></div>'
+        '<div server-rendered="true" style="text-align:left;font-size:520rem;color:red;"></div>'
       )
       done()
     })
@@ -178,7 +178,7 @@ describe('SSR: renderToString', () => {
       }
     }, result => {
       expect(result).toContain(
-        '<div server-rendered="true" style="color:red"><div></div></div>'
+        '<div server-rendered="true" style="color:red;"><div></div></div>'
       )
       done()
     })
@@ -197,7 +197,7 @@ describe('SSR: renderToString', () => {
       }
     }, result => {
       expect(result).toContain(
-        '<div server-rendered="true" style="color:red"><span style="color:black"></span></div>'
+        '<div server-rendered="true" style="color:red;"><span style="color:black;"></span></div>'
       )
       done()
     })

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ function genStyleText (vnode: VNode): string {`
`8`	`8`	`for (const key in style) {`
`9`	`9`	styleText += `${hyphenate(key)}:${style[key]};`
`10`	`10`	`}`
`11`		`- return styleText.slice(0, -1)`
	`11`	`+ return styleText`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`export default function renderStyle (vnode: VNodeWithData): ?string {`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ describe('SSR: renderToString', () => {`
`102`	`102`	`}`
`103`	`103`	`}, result => {`
`104`	`104`	`expect(result).toContain(`
`105`		`- '<div server-rendered="true" style="background-color:black;font-size:14px;color:red"></div>'`
	`105`	`+ '<div server-rendered="true" style="background-color:black;font-size:14px;color:red;"></div>'`
`106`	`106`	`)`
`107`	`107`	`done()`
`108`	`108`	`})`
`@@ -116,7 +116,7 @@ describe('SSR: renderToString', () => {`
`116`	`116`	`}`
`117`	`117`	`}, result => {`
`118`	`118`	`expect(result).toContain(`
`119`		`- '<div server-rendered="true" style="color:red"></div>'`
	`119`	`+ '<div server-rendered="true" style="color:red;"></div>'`
`120`	`120`	`)`
`121`	`121`	`done()`
`122`	`122`	`})`
`@@ -135,7 +135,7 @@ describe('SSR: renderToString', () => {`
`135`	`135`	`}`
`136`	`136`	`}, result => {`
`137`	`137`	`expect(result).toContain(`
`138`		`- '<section server-rendered="true"><div style="color:red"></div></section>'`
	`138`	`+ '<section server-rendered="true"><div style="color:red;"></div></section>'`
`139`	`139`	`)`
`140`	`140`	`done()`
`141`	`141`	`})`
`@@ -159,7 +159,7 @@ describe('SSR: renderToString', () => {`
`159`	`159`	`}`
`160`	`160`	`}, result => {`
`161`	`161`	`expect(result).toContain(`
`162`		`- '<div server-rendered="true" style="text-align:left;font-size:520rem;color:red"></div>'`
	`162`	`+ '<div server-rendered="true" style="text-align:left;font-size:520rem;color:red;"></div>'`
`163`	`163`	`)`
`164`	`164`	`done()`
`165`	`165`	`})`
`@@ -178,7 +178,7 @@ describe('SSR: renderToString', () => {`
`178`	`178`	`}`
`179`	`179`	`}, result => {`
`180`	`180`	`expect(result).toContain(`
`181`		`- '<div server-rendered="true" style="color:red"><div></div></div>'`
	`181`	`+ '<div server-rendered="true" style="color:red;"><div></div></div>'`
`182`	`182`	`)`
`183`	`183`	`done()`
`184`	`184`	`})`
`@@ -197,7 +197,7 @@ describe('SSR: renderToString', () => {`
`197`	`197`	`}`
`198`	`198`	`}, result => {`
`199`	`199`	`expect(result).toContain(`
`200`		`- '<div server-rendered="true" style="color:red"><span style="color:black"></span></div>'`
	`200`	`+ '<div server-rendered="true" style="color:red;"><span style="color:black;"></span></div>'`
`201`	`201`	`)`
`202`	`202`	`done()`
`203`	`203`	`})`