Fix orderBy with primitive values by passing true

posva · posva · commit d532af71ae38 · 2016-03-30T21:09:11.000+02:00
Introduced by 04a213b
diff --git a/src/filters/array-filters.js b/src/filters/array-filters.js
@@ -84,7 +84,9 @@ export function orderBy (arr, sortKeys, order) {
 
   if (typeof sortKeys === 'string') {
     sortKeys = [sortKeys]
-  } else if (!sortKeys || !sortKeys.length) {
+  } else if (!sortKeys || (sortKeys !== true && !sortKeys.length)) {
+    // we check if sortKeys === true because you can sort primitive values with
+    // array | orderBy true: http://vuejs.org/api/#orderBy
     return arr
   }
 
@@ -101,7 +103,9 @@ export function orderBy (arr, sortKeys, order) {
 
   function recursiveCompare (a, b, i) {
     i = i || 0
-    if (i === sortKeys.length - 1) return compare(a, b, i)
+    if (sortKeys === true || i === sortKeys.length - 1) {
+      return compare(a, b, i)
+    }
     return compare(a, b, i) || recursiveCompare(a, b, i + 1)
   }
 
diff --git a/test/unit/specs/filters/filters_spec.js b/test/unit/specs/filters/filters_spec.js
@@ -230,6 +230,13 @@ describe('Filters', function () {
     assertArray(res, [arr[1], arr[2], arr[0]])
   })
 
+  it('orderBy primitive values', function () {
+    var filter = filters.orderBy
+    var arr = [9, 11, 1, 2]
+    var res = filter(arr, true)
+    assertArray(res, [arr[2], arr[3], arr[0], arr[1]])
+  })
+
   it('orderBy multiple fields', function () {
     var filter = filters.orderBy
     var arr = [
