fix nextTick Promise implementation for polyfills

yyx990803 · yyx990803 · commit f242e119fab4 · 2016-11-20T12:03:24.000-05:00
diff --git a/src/core/util/env.js b/src/core/util/env.js
@@ -86,18 +86,20 @@ export const nextTick = (function () {
     }
   }
 
-  return function queueNextTick (cb: Function, ctx?: Object) {
-    if (cb) {
-      var func = ctx
-        ? function () { cb.call(ctx) }
-        : cb
-      callbacks.push(func)
-      if (!pending) {
-        pending = true
-        timerFunc()
-      }
-    } else if (typeof Promise !== 'undefined') {
-      return Promise.resolve(ctx)
+  return function queueNextTick (cb?: Function, ctx?: Object) {
+    let _resolve
+    callbacks.push(() => {
+      if (cb) cb.call(ctx)
+      if (_resolve) _resolve(ctx)
+    })
+    if (!pending) {
+      pending = true
+      timerFunc()
+    }
+    if (!cb && typeof Promise !== 'undefined') {
+      return new Promise(resolve => {
+        _resolve = resolve
+      })
     }
   }
 })()
diff --git a/test/unit/features/instance/methods-lifecycle.spec.js b/test/unit/features/instance/methods-lifecycle.spec.js
@@ -119,7 +119,7 @@ describe('Instance methods lifecycle', () => {
           }
         }).$mount()
         vm.msg = 'bar'
-        vm.$nextTick().then(function (ctx) {
+        vm.$nextTick().then(ctx => {
           expect(ctx).toBe(vm)
           expect(vm.$el.textContent).toBe('bar')
           done()
diff --git a/test/unit/index.js b/test/unit/index.js
@@ -1,3 +1,5 @@
+require('es6-promise/auto')
+
 // import all helpers
 const helpersContext = require.context('../helpers', true)
 helpersContext.keys().forEach(helpersContext)
diff --git a/test/unit/modules/util/next-tick.spec.js b/test/unit/modules/util/next-tick.spec.js
@@ -6,7 +6,7 @@ describe('nextTick', () => {
   })
 
   it('returns undefined when passed a callback', () => {
-    expect(typeof nextTick(() => {})).toBe('undefined')
+    expect(nextTick(() => {})).toBeUndefined()
   })
 
   if (typeof Promise !== 'undefined') {
@@ -21,5 +21,14 @@ describe('nextTick', () => {
         done()
       })
     })
+
+    it('returned Promise should resolve correctly vs callback', done => {
+      const spy = jasmine.createSpy()
+      nextTick(spy)
+      nextTick().then(() => {
+        expect(spy).toHaveBeenCalled()
+        done()
+      })
+    })
   }
 })

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ describe('Instance methods lifecycle', () => {`
`119`	`119`	`}`
`120`	`120`	`}).$mount()`
`121`	`121`	`vm.msg = 'bar'`
`122`		`- vm.$nextTick().then(function (ctx) {`
	`122`	`+ vm.$nextTick().then(ctx => {`
`123`	`123`	`expect(ctx).toBe(vm)`
`124`	`124`	`expect(vm.$el.textContent).toBe('bar')`
`125`	`125`	`done()`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+require('es6-promise/auto')`
	`2`	`+`
`1`	`3`	`// import all helpers`
`2`	`4`	`const helpersContext = require.context('../helpers', true)`
`3`	`5`	`helpersContext.keys().forEach(helpersContext)`