Add some tests for invalid addresses with quotes in preparation for parsing them

JoshData · JoshData · commit 8fdbaba8e674 · 2023-04-10T15:21:31.000-04:00
diff --git a/email_validator/syntax.py b/email_validator/syntax.py
@@ -17,6 +17,8 @@ def get_length_reason(addr, utf8=False, limit=EMAIL_MAX_LENGTH):
 
 def safe_character_display(c):
     # Return safely displayable characters in quotes.
+    if c == '\\':
+        return f"\"{c}\""  # can't use repr because it escapes it
     if unicodedata.category(c)[0] in ("L", "N", "P", "S"):
         return repr(c)
 
diff --git a/tests/test_syntax.py b/tests/test_syntax.py
@@ -223,6 +223,24 @@ def test_email_valid_intl_local_part(email_input, output):
     assert "Internationalized characters before the @-sign are not supported: " in str(exc_info.value)
 
 
+@pytest.mark.parametrize(
+    'email_input,error_msg',
+    [
+        ('"unnecessarily.quoted.local.part"@example.com', 'The email address contains invalid characters before the @-sign: \'"\'.'),
+        ('"quoted..local.part"@example.com', 'The email address contains invalid characters before the @-sign: \'"\'.'),
+        ('"quoted.with.at@"@example.com', 'The email address is not valid. It must have exactly one @-sign.'),
+        ('"quoted with space"@example.com', 'The email address contains invalid characters before the @-sign: \'\"\', SPACE.'),
+        ('"quoted.with.dquote\\""@example.com', 'The email address contains invalid characters before the @-sign: "\\", \'"\'.'),
+        ('"unnecessarily.quoted.with.unicode.λ"@example.com', 'The email address contains invalid characters before the @-sign: \'"\'.'),
+        ('"quoted.with..unicode.λ"@example.com', 'The email address contains invalid characters before the @-sign: \'"\'.'),
+        ('"quoted.with.extraneous.\\escape"@example.com', 'The email address contains invalid characters before the @-sign: "\\", \'"\'.'),
+    ])
+def test_email_valid_only_if_quoted_local_part(email_input, error_msg):
+    with pytest.raises(EmailSyntaxError) as exc_info:
+        validate_email(email_input)
+    assert str(exc_info.value) == error_msg
+
+
 @pytest.mark.parametrize(
     'email_input,error_msg',
     [
@@ -261,11 +279,8 @@ def test_email_valid_intl_local_part(email_input, output):
         ('\nmy@example.com', 'The email address contains invalid characters before the @-sign: U+000A.'),
         ('m\ny@example.com', 'The email address contains invalid characters before the @-sign: U+000A.'),
         ('my\n@example.com', 'The email address contains invalid characters before the @-sign: U+000A.'),
-<<<<<<< HEAD
-=======
         ('test@\n', 'The part after the @-sign contains invalid characters: U+000A.'),
         ('bad"quotes"@example.com', 'The email address contains invalid characters before the @-sign: \'"\'.'),
->>>>>>> 6146614 (fixup)
         ('11111111112222222222333333333344444444445555555555666666666677777@example.com', 'The email address is too long before the @-sign (1 character too many).'),
         ('111111111122222222223333333333444444444455555555556666666666777777@example.com', 'The email address is too long before the @-sign (2 characters too many).'),
         ('me@1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.111111111122222222223333333333444444444455555555556.com', 'The email address is too long (4 characters too many).'),
@@ -343,7 +358,7 @@ def test_email_unsafe_character(s, expected_error):
         ('λambdaツ@test', 'Internationalized characters before the @-sign are not supported: \'λ\', \'ツ\'.'),
     ],
 )
-def test_email_invalid_character_smtputf8(email_input, expected_error):
+def test_email_invalid_character_smtputf8_off(email_input, expected_error):
     # Check that internationalized characters are rejected if allow_smtputf8=False.
     with pytest.raises(EmailSyntaxError) as exc_info:
         validate_email(email_input, allow_smtputf8=False, test_environment=True)
