feat(api): make RecordHardlinks fallible

KSXGitHub · KSXGitHub · commit d3656d573d5f · 2025-07-16T14:43:58.000+07:00
diff --git a/src/fs_tree_builder.rs b/src/fs_tree_builder.rs
@@ -98,9 +98,11 @@ where
                         let is_dir = stats.is_dir();
                         let size = size_getter.get_size(&stats);
                         reporter.report(Event::ReceiveData(size));
-                        hardlinks_recorder.record_hardlinks(RecordHardlinksArgument::new(
-                            path, &stats, size, reporter,
-                        ));
+                        hardlinks_recorder
+                            .record_hardlinks(RecordHardlinksArgument::new(
+                                path, &stats, size, reporter,
+                            ))
+                            .ok(); // ignore the error for now
                         (is_dir, size)
                     }
                 };
diff --git a/src/hardlink/aware.rs b/src/hardlink/aware.rs
@@ -1,5 +1,6 @@
 use super::{
-    DeduplicateSharedSize, HardlinkList, LinkPathList, RecordHardlinks, RecordHardlinksArgument,
+    hardlink_list, DeduplicateSharedSize, HardlinkList, LinkPathList, RecordHardlinks,
+    RecordHardlinksArgument,
 };
 use crate::{
     data_tree::DataTree,
@@ -8,7 +9,7 @@ use crate::{
     reporter::{event::HardlinkDetection, Event, Reporter},
     size,
 };
-use derive_more::{AsMut, AsRef, From, Into};
+use derive_more::{AsMut, AsRef, Display, Error, From, Into};
 use pipe_trait::Pipe;
 use smart_default::SmartDefault;
 use std::{convert::Infallible, fmt::Debug, os::unix::fs::MetadataExt, path::Path};
@@ -37,12 +38,26 @@ impl<Size> Aware<Size> {
     }
 }
 
+/// Error that occurs when [`Aware::record_hardlinks`] fails.
+#[derive(Debug, Display, Error)]
+#[non_exhaustive]
+pub enum ReportHardlinksError<Size> {
+    /// Fail to add an entry to the record.
+    #[display("Fail to add an entry to record: {_0}")]
+    AddToRecord(hardlink_list::AddError<Size>),
+}
+
 impl<Size, Report> RecordHardlinks<Size, Report> for Aware<Size>
 where
     Size: size::Size + Eq + Debug,
     Report: Reporter<Size> + ?Sized,
 {
-    fn record_hardlinks(&self, argument: RecordHardlinksArgument<Size, Report>) {
+    type Error = ReportHardlinksError<Size>;
+
+    fn record_hardlinks(
+        &self,
+        argument: RecordHardlinksArgument<Size, Report>,
+    ) -> Result<(), Self::Error> {
         let RecordHardlinksArgument {
             path,
             stats,
@@ -51,12 +66,12 @@ where
         } = argument;
 
         if stats.is_dir() {
-            return;
+            return Ok(());
         }
 
         let links = stats.nlink();
         if links <= 1 {
-            return;
+            return Ok(());
         }
 
         reporter.report(Event::DetectHardlink(HardlinkDetection {
@@ -67,7 +82,9 @@ where
         }));
 
         let ino = InodeNumber::get(stats);
-        self.record.add(ino, size, path).unwrap(); // TODO: propagate the error
+        self.record
+            .add(ino, size, path)
+            .map_err(ReportHardlinksError::AddToRecord)
     }
 }
 
diff --git a/src/hardlink/ignorant.rs b/src/hardlink/ignorant.rs
@@ -12,8 +12,16 @@ pub use Ignorant as HardlinkIgnorant;
 
 /// Do nothing to detect nor record any hardlink.
 impl<Size, Reporter> RecordHardlinks<Size, Reporter> for Ignorant {
+    /// Doing nothing cannot fail.
+    type Error = Infallible;
+
     /// Do nothing.
-    fn record_hardlinks(&self, _: RecordHardlinksArgument<Size, Reporter>) {}
+    fn record_hardlinks(
+        &self,
+        _: RecordHardlinksArgument<Size, Reporter>,
+    ) -> Result<(), Self::Error> {
+        Ok(())
+    }
 }
 
 /// Do nothing to deduplicate the sizes of hardlinks.
diff --git a/src/hardlink/record.rs b/src/hardlink/record.rs
@@ -29,8 +29,10 @@ impl<'a, Size, Report: ?Sized> Argument<'a, Size, Report> {
 
 /// Ability to detect and record hardlinks.
 pub trait RecordHardlinks<Size, Reporter: ?Sized> {
+    /// Error when [`RecordHardlinks::record_hardlinks`] fails.
+    type Error;
     /// Perform hardlinks detection and recording.
-    fn record_hardlinks(&self, argument: Argument<Size, Reporter>);
+    fn record_hardlinks(&self, argument: Argument<Size, Reporter>) -> Result<(), Self::Error>;
 }
 
 /// Do detect and record hardlinks.
