Refactor file_reader.py

ashikkumar23 · ashikkumar23 · commit 33fb5f5561f3 · 2023-01-21T20:01:41.000+05:30
diff --git a/utils/file_reader.py b/utils/file_reader.py
@@ -1,18 +1,16 @@
 import json
 from pathlib import Path
 
-BASE_PATH = Path.cwd().joinpath("data")
+BASE_PATH = Path.cwd() / "data"
 
 
-def read_file(file_name):
+def read_file(file_name: str) -> dict:
     file_path = get_file_with_json_ext(file_name)
     with open(file_path, mode="r", encoding="utf-8") as f:
         return json.load(f)
 
 
-def get_file_with_json_ext(file_name):
-    return (
-        BASE_PATH.joinpath(file_name)
-        if ".json" in file_name
-        else BASE_PATH.joinpath(f"{file_name}.json")
-    )
+def get_file_with_json_ext(file_name: str) -> Path:
+    if not file_name.endswith(".json"):
+        file_name += ".json"
+    return BASE_PATH / file_name
