Use builtin min/max in hlines/vlines

phobson · phobson · commit 61c214eb4d6c · 2016-11-07T11:10:19.000-08:00
This is a little simpler since we're finding the min
or max of two scalars (avoids an intermediate list +
diving into numpy).

Also synced up the decorator between the two functions.
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -919,7 +919,8 @@ def axvspan(self, xmin, xmax, ymin=0, ymax=1, **kwargs):
         self.autoscale_view(scaley=False)
         return p
 
-    @_preprocess_data(replace_names=['y', 'xmin', 'xmax'], label_namer="y")
+    @_preprocess_data(replace_names=['y', 'xmin', 'xmax', 'colors'],
+                      label_namer='y')
     def hlines(self, y, xmin, xmax, colors='k', linestyles='solid',
                label='', **kwargs):
         """
@@ -986,8 +987,8 @@ def hlines(self, y, xmin, xmax, colors='k', linestyles='solid',
         lines.update(kwargs)
 
         if len(y) > 0:
-            minx = np.min([xmin.min(), xmax.min()])
-            maxx = np.max([xmin.max(), xmax.max()])
+            minx = min(xmin.min(), xmax.min())
+            maxx = max(xmin.max(), xmax.max())
             miny = y.min()
             maxy = y.max()
 
@@ -998,8 +999,8 @@ def hlines(self, y, xmin, xmax, colors='k', linestyles='solid',
 
         return lines
 
-    @_preprocess_data(replace_names=["x", "ymin", "ymax", "colors"],
-                         label_namer="x")
+    @_preprocess_data(replace_names=['x', 'ymin', 'ymax', 'colors'],
+                      label_namer='x')
     def vlines(self, x, ymin, ymax, colors='k', linestyles='solid',
                label='', **kwargs):
         """
@@ -1071,8 +1072,8 @@ def vlines(self, x, ymin, ymax, colors='k', linestyles='solid',
         if len(x) > 0:
             minx = x.min()
             maxx = x.max()
-            miny = np.min([ymin.min(), ymax.min()])
-            maxy = np.max([ymin.max(), ymax.max()])
+            miny = min(ymin.min(), ymax.min())
+            maxy = max(ymin.max(), ymax.max())
 
             corners = (minx, miny), (maxx, maxy)
             self.update_datalim(corners)
