From 5e679425fd870939e542795c2ac12739fcca031d Mon Sep 17 00:00:00 2001 From: "sheche@microsoft.com" Date: Sat, 24 Feb 2018 15:28:54 +0800 Subject: [PATCH] fix #10 --- CHANGELOG.md | 3 +++ src/leetCodeManager.ts | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index da33633b..4cc7d587 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,9 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how ### Added - Support setting the default language to solve problems [(#5)](https://github.com/jdneo/vscode-leetcode/issues/5) +### Fixed +- When user cancels login, no further actions will happen [(#10)](https://github.com/jdneo/vscode-leetcode/issues/10) + ## [0.1.2] ### Fixed - Fix the deplicated nodes in LeetCode Explorer bug [(#6)](https://github.com/jdneo/vscode-leetcode/issues/6) diff --git a/src/leetCodeManager.ts b/src/leetCodeManager.ts index af73e882..95f0c426 100644 --- a/src/leetCodeManager.ts +++ b/src/leetCodeManager.ts @@ -59,7 +59,7 @@ class LeetCodeManager extends EventEmitter implements ILeetCodeManager { }); if (!name) { childProc.kill(); - resolve(undefined); + return resolve(undefined); } childProc.stdin.write(`${name}\n`); const pwd: string | undefined = await vscode.window.showInputBox({ @@ -69,7 +69,7 @@ class LeetCodeManager extends EventEmitter implements ILeetCodeManager { }); if (!pwd) { childProc.kill(); - resolve(undefined); + return resolve(undefined); } childProc.stdin.write(`${pwd}\n`); childProc.stdin.end();