Re-enable logging during broker version check (dpkp#1430)

dpkp · web-flow · commit 3dc536aa72c3 · 2018-03-09T17:18:04.000-05:00
diff --git a/kafka/conn.py b/kafka/conn.py
@@ -906,6 +906,7 @@ def check_version(self, timeout=2, strict=False):
 
         Returns: version tuple, i.e. (0, 10), (0, 9), (0, 8, 2), ...
         """
+        log.info('Probing node %s broker version', self.node_id)
         # Monkeypatch some connection configurations to avoid timeouts
         override_config = {
             'request_timeout_ms': timeout * 1000,
@@ -924,17 +925,6 @@ def check_version(self, timeout=2, strict=False):
         from kafka.protocol.admin import ApiVersionRequest, ListGroupsRequest
         from kafka.protocol.commit import OffsetFetchRequest, GroupCoordinatorRequest
 
-        # Socket errors are logged as exceptions and can alarm users. Mute them
-        from logging import Filter
-
-        class ConnFilter(Filter):
-            def filter(self, record):
-                if record.funcName == 'check_version':
-                    return True
-                return False
-        log_filter = ConnFilter()
-        log.addFilter(log_filter)
-
         test_cases = [
             # All cases starting from 0.10 will be based on ApiVersionResponse
             ((0, 10), ApiVersionRequest[0]()),
@@ -1004,7 +994,6 @@ def filter(self, record):
         else:
             raise Errors.UnrecognizedBrokerVersion()
 
-        log.removeFilter(log_filter)
         for key in stashed:
             self.config[key] = stashed[key]
         return version
