fix: responder select query bug

sarike · sarike · commit 2dd72fa69561 · 2023-02-23T20:27:38.000+08:00
diff --git a/client/packages/openblocks-design/src/components/query.tsx b/client/packages/openblocks-design/src/components/query.tsx
@@ -110,6 +110,9 @@ export const QueryConfigItemWrapper = styled.div<{ direction?: "row" | "column"
 type TutorialStyle = "dropdownRight" | "begin";
 
 const TutorialButtonWrapper = styled.div<{ styleName: TutorialStyle }>`
+  height: 100%;
+  display: flex;
+  align-items: center;
   ${(props) => {
     if (props.styleName === "dropdownRight") {
       return css`
diff --git a/client/packages/openblocks/src/comps/comps/dataChangeResponderComp.tsx b/client/packages/openblocks/src/comps/comps/dataChangeResponderComp.tsx
@@ -53,6 +53,7 @@ const DataResponderItemCompBase = new MultiCompBuilder(
                     label: trans("dataResponder.data"),
                     tooltip: trans("dataResponder.dataTooltip"),
                     placement: "bottom",
+                    placeholder: "{{anyDependencies}}",
                     extraChildren: QueryTutorials.dataResponder && (
                       <DocLink style={{ marginTop: 8 }} href={QueryTutorials.dataResponder}>
                         {trans("dataResponder.docLink")}
@@ -133,6 +134,6 @@ export const DataChangeResponderListComp = bottomResListComp(
   DataChangeResponderItemComp,
   DataResponderCompType,
   {
-    data: JSON.stringify({}),
+    data: "",
   }
 );
diff --git a/client/packages/openblocks/src/comps/controls/actionSelector/executeQueryAction.tsx b/client/packages/openblocks/src/comps/controls/actionSelector/executeQueryAction.tsx
@@ -56,11 +56,15 @@ export class ExecuteQueryAction extends ExecuteQueryTmpAction {
           }))
           .filter(
             // Filter out the current query under query
-            (option) =>
-              placement !== "query" ||
-              (placement === "query" &&
-                editorState.selectedBottomResType === BottomResTypeEnum.Query &&
-                option.value !== editorState.selectedBottomResName)
+            (option) => {
+              if (
+                placement === "query" &&
+                editorState.selectedBottomResType === BottomResTypeEnum.Query
+              ) {
+                return option.value !== editorState.selectedBottomResName;
+              }
+              return true;
+            }
           ) || [];
 
       // input queries
diff --git a/client/packages/openblocks/src/comps/editorState.tsx b/client/packages/openblocks/src/comps/editorState.tsx
@@ -139,7 +139,22 @@ export class EditorState {
     const queryComInfoList = this.queryCompInfoList();
     const stateComInfoList = this.getTempStateCompInfoList();
     const transformerComInfoList = this.getTransformerCompInfoList();
-    return [...queryComInfoList, ...stateComInfoList, ...transformerComInfoList];
+    const dataResponderInfoList = this.getDataResponderInfoList();
+    return [
+      ...queryComInfoList,
+      ...stateComInfoList,
+      ...transformerComInfoList,
+      ...dataResponderInfoList,
+    ];
+  }
+
+  getDataResponderInfoList(): Array<CompInfo> {
+    const listComp = this.getDataRespondersComp();
+    const exposingInfo = listComp.nameAndExposingInfo();
+    return listComp.getView().map((item) => {
+      const name = item.children.name.getView();
+      return this.getCompInfo(exposingInfo, name, BottomResTypeEnum.DateResponder);
+    });
   }
 
   getTempStateCompInfoList(): Array<CompInfo> {
diff --git a/client/packages/openblocks/src/i18n/locales/en.ts b/client/packages/openblocks/src/i18n/locales/en.ts
@@ -1496,8 +1496,7 @@ export const en = {
   dataResponder: {
     data: "Data",
     dataDesc: "Data of current data responder",
-    dataTooltip:
-      "The dependent data that it's change will trigger the actions of current responder",
+    dataTooltip: "When this data is changed, it will trigger subsequent actions.",
     docLink: "About the Data responder",
     deleteMessage: "The data responder is deleted successfully. You can use {undoKey} to undo.",
   },
diff --git a/client/packages/openblocks/src/pages/setting/settingHome.tsx b/client/packages/openblocks/src/pages/setting/settingHome.tsx
@@ -42,6 +42,14 @@ export function SettingHome() {
       key: SettingPageEnum.Organization,
       label: trans("settings.organization"),
     },
+    ...(isEE() && currentOrgAdmin(user) && (isSelfDomain(config) || isEnterpriseMode(config))
+      ? [
+          {
+            key: SettingPageEnum.IdSource,
+            label: trans("settings.idSource"),
+          },
+        ]
+      : []),
     ...(showAuditLog(config) && currentOrgAdmin(user)
       ? [
           {
@@ -70,14 +78,6 @@ export function SettingHome() {
       key: SettingPageEnum.Advanced,
       label: trans("settings.advanced"),
     },
-    ...(isEE() && currentOrgAdmin(user) && (isSelfDomain(config) || isEnterpriseMode(config))
-      ? [
-          {
-            key: SettingPageEnum.IdSource,
-            label: trans("settings.idSource"),
-          },
-        ]
-      : []),
   ];
 
   return (
diff --git a/client/packages/openblocks/src/util/envUtils.ts b/client/packages/openblocks/src/util/envUtils.ts
@@ -30,7 +30,7 @@ export function isSelfDomain(config?: SystemConfig) {
 }
 
 export function showAuditLog(config?: SystemConfig) {
-  return config?.featureFlag.enableAuditLog;
+  return config?.featureFlag?.enableAuditLog;
 }
 
 export function useCloudHosting() {

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ export function isSelfDomain(config?: SystemConfig) {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`export function showAuditLog(config?: SystemConfig) {`
`33`		`- return config?.featureFlag.enableAuditLog;`
	`33`	`+ return config?.featureFlag?.enableAuditLog;`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`export function useCloudHosting() {`