memoize text comp

raheeliftikhar5 · raheeliftikhar5 · commit 64dc3028ab84 · 2024-09-12T23:45:50.000+05:00
diff --git a/client/packages/lowcoder/src/comps/comps/textComp.tsx b/client/packages/lowcoder/src/comps/comps/textComp.tsx
@@ -21,6 +21,9 @@ import { PaddingControl } from "../controls/paddingControl";
 import React, { useContext, useEffect } from "react";
 import { EditorContext } from "comps/editorState";
 import { clickEvent, eventHandlerControl } from "../controls/eventHandlerControl";
+import { NewChildren } from "../generators/uiCompBuilder";
+import { RecordConstructorToComp } from "lowcoder-core";
+import { ToViewReturn } from "../generators/multi";
 
 const EventOptions = [clickEvent] as const;
 
@@ -130,87 +133,95 @@ const VerticalAlignmentOptions = [
   { label: <AlignVerticalCenter />, value: "center" },
   { label: <AlignBottom />, value: "flex-end" },
 ] as const;
+const childrenMap = {
+  text: stringExposingStateControl(
+    "text",
+    trans("textShow.text", { name: "{{currentUser.name}}" })
+  ),
+  onEvent: eventHandlerControl(EventOptions),
+  autoHeight: AutoHeightControl,
+  type: dropdownControl(typeOptions, "markdown"),
+  horizontalAlignment: alignWithJustifyControl(),
+  verticalAlignment: dropdownControl(VerticalAlignmentOptions, "center"),
+  style: styleControl(TextStyle, 'style'),
+  animationStyle: styleControl(AnimationStyle, 'animationStyle'),
+  margin: MarginControl,
+  padding: PaddingControl,
+};
 
-let TextTmpComp = (function () {
-  const childrenMap = {
-    text: stringExposingStateControl(
-      "text",
-      trans("textShow.text", { name: "{{currentUser.name}}" })
-    ),
-    onEvent: eventHandlerControl(EventOptions),
-    autoHeight: AutoHeightControl,
-    type: dropdownControl(typeOptions, "markdown"),
-    horizontalAlignment: alignWithJustifyControl(),
-    verticalAlignment: dropdownControl(VerticalAlignmentOptions, "center"),
-    style: styleControl(TextStyle, 'style'),
-    animationStyle: styleControl(AnimationStyle, 'animationStyle'),
-    margin: MarginControl,
-    padding: PaddingControl,
-  };
-  return new UICompBuilder(childrenMap, (props, dispatch) => {
-    const value = props.text.value;
-  
-    return (
-      <TextContainer
-        $animationStyle={props.animationStyle}
-        $type={props.type}
-        $styleConfig={props.style}
-        style={{
-          justifyContent: props.horizontalAlignment,
-          alignItems: props.autoHeight ? "center" : props.verticalAlignment,
-          textAlign: props.horizontalAlignment,
-          rotate: props.style.rotation
-        }}
-        onClick={() => props.onEvent("click")}
-      >
-        {props.type === "markdown" ? <TacoMarkDown>{value}</TacoMarkDown> : value}
-      </TextContainer>
-    );
-  })
-    .setPropertyViewFn((children) => {
-      return (
+type ChildrenType = NewChildren<RecordConstructorToComp<typeof childrenMap>>;
+
+const TextPropertyView = React.memo((props: {
+  children: ChildrenType
+}) => {
+  return (
+    <>
+      <Section name={sectionNames.basic}>
+        {props.children.type.propertyView({
+          label: trans("value"),
+          tooltip: trans("textShow.valueTooltip"),
+          radioButton: true,
+        })}
+        {props.children.text.propertyView({})}
+      </Section>
+
+      {["logic", "both"].includes(useContext(EditorContext).editorModeStatus) && (
+        <Section name={sectionNames.interaction}>
+          {hiddenPropertyView(props.children)}
+          {props.children.onEvent.getPropertyView()}
+        </Section>
+      )}
+
+      {["layout", "both"].includes(useContext(EditorContext).editorModeStatus) && (
         <>
-          <Section name={sectionNames.basic}>
-            {children.type.propertyView({
-              label: trans("value"),
-              tooltip: trans("textShow.valueTooltip"),
+          <Section name={sectionNames.layout}>
+            {props.children.autoHeight.getPropertyView()}
+            {!props.children.autoHeight.getView() &&
+              props.children.verticalAlignment.propertyView({
+                label: trans("textShow.verticalAlignment"),
+                radioButton: true,
+              })}
+            {props.children.horizontalAlignment.propertyView({
+              label: trans("textShow.horizontalAlignment"),
               radioButton: true,
             })}
-            {children.text.propertyView({})}
           </Section>
-
-          {["logic", "both"].includes(useContext(EditorContext).editorModeStatus) && (
-            <Section name={sectionNames.interaction}>
-              {hiddenPropertyView(children)}
-              {children.onEvent.getPropertyView()}
-            </Section>
-          )}
-
-          {["layout", "both"].includes(useContext(EditorContext).editorModeStatus) && (
-            <>
-              <Section name={sectionNames.layout}>
-                {children.autoHeight.getPropertyView()}
-                {!children.autoHeight.getView() &&
-                  children.verticalAlignment.propertyView({
-                    label: trans("textShow.verticalAlignment"),
-                    radioButton: true,
-                  })}
-                {children.horizontalAlignment.propertyView({
-                  label: trans("textShow.horizontalAlignment"),
-                  radioButton: true,
-                })}
-              </Section>
-              <Section name={sectionNames.style}>
-                {children.style.getPropertyView()}
-              </Section>
-              <Section name={sectionNames.animationStyle} hasTooltip={true}>
-                {children.animationStyle.getPropertyView()}
-              </Section>
-            </>
-          )}
+          <Section name={sectionNames.style}>
+            {props.children.style.getPropertyView()}
+          </Section>
+          <Section name={sectionNames.animationStyle} hasTooltip={true}>
+            {props.children.animationStyle.getPropertyView()}
+          </Section>
         </>
-      );
-    })
+      )}
+    </>
+  );
+})
+
+const TextView = React.memo((props: ToViewReturn<ChildrenType>) => {
+  const value = props.text.value;
+
+  return (
+    <TextContainer
+      $animationStyle={props.animationStyle}
+      $type={props.type}
+      $styleConfig={props.style}
+      style={{
+        justifyContent: props.horizontalAlignment,
+        alignItems: props.autoHeight ? "center" : props.verticalAlignment,
+        textAlign: props.horizontalAlignment,
+        rotate: props.style.rotation
+      }}
+      onClick={() => props.onEvent("click")}
+    >
+      {props.type === "markdown" ? <TacoMarkDown>{value}</TacoMarkDown> : value}
+    </TextContainer>
+  );
+}, (prev, next) => JSON.stringify(prev) === JSON.stringify(next));
+
+let TextTmpComp = (function () {
+  return new UICompBuilder(childrenMap, (props) => <TextView {...props} />)
+    .setPropertyViewFn((children) => <TextPropertyView children={children} />)
     .build();
 })();
 
