feat(privateNpmRegistry): cleanup and comments

hulutter · hulutter · commit 9857ef2b38aa · 2024-07-31T11:56:43.000+02:00
diff --git a/server/node-service/src/routes/apiRouter.ts b/server/node-service/src/routes/apiRouter.ts
@@ -13,10 +13,12 @@ apiRouter.post("/runPluginQuery", pluginControllers.runPluginQuery);
 apiRouter.post("/getPluginDynamicConfig", pluginControllers.getDynamicDef);
 apiRouter.post("/validatePluginDataSourceConfig", pluginControllers.validatePluginDataSourceConfig);
 
-apiRouter.get("/npm/registry/*", npmControllers.fetchRegistry);
-apiRouter.get("/npm/package/*", npmControllers.fetchPackageFile);
-
+// routes for npm registry and package fetching with config called by the api-service
 apiRouter.post("/npm/registry/*", npmControllers.fetchRegistryWithConfig);
 apiRouter.post("/npm/package/*", npmControllers.fetchPackageFileWithConfig);
 
+// temporary routes for testing npm registry and package routes by directly calling the node-service
+apiRouter.get("/npm/registry/*", npmControllers.fetchRegistry);
+apiRouter.get("/npm/package/*", npmControllers.fetchPackageFile);
+
 export default apiRouter;
diff --git a/server/node-service/src/services/npmRegistry.ts b/server/node-service/src/services/npmRegistry.ts
@@ -75,7 +75,7 @@ export class NpmRegistryService {
             const config = JSON.parse(registryConfig);
             return NpmRegistryService.sortRegistryConfig(config);
         } catch (error) {
-            console.error("Error parsing registry config", error);
+            logger.error(`Error parsing NPM registry config: ${error}`);
             return [];
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export class NpmRegistryService {`
`75`	`75`	`const config = JSON.parse(registryConfig);`
`76`	`76`	`return NpmRegistryService.sortRegistryConfig(config);`
`77`	`77`	`} catch (error) {`
`78`		`- console.error("Error parsing registry config", error);`
	`78`	+ logger.error(`Error parsing NPM registry config: ${error}`);
`79`	`79`	`return [];`
`80`	`80`	`}`
`81`	`81`	`}`