comm: permit and test separators that contain a hyphen

BenWiederhake · BenWiederhake · commit 1fa0b032e55c · 2024-03-23T23:35:40.000+01:00
diff --git a/src/uu/comm/src/comm.rs b/src/uu/comm/src/comm.rs
@@ -186,6 +186,7 @@ pub fn uu_app() -> Command {
                 .help("separate columns with STR")
                 .value_name("STR")
                 .default_value(options::DELIMITER_DEFAULT)
+                .allow_hyphen_values(true)
                 .hide_default_value(true),
         )
         .arg(
diff --git a/tests/by-util/test_comm.rs b/tests/by-util/test_comm.rs
@@ -91,6 +91,22 @@ fn output_delimiter() {
         .stdout_only_fixture("ab_delimiter_word.expected");
 }
 
+#[test]
+fn output_delimiter_hyphen_one() {
+    new_ucmd!()
+        .args(&["--output-delimiter", "-1", "a", "b"])
+        .succeeds()
+        .stdout_only_fixture("ab_delimiter_hyphen_one.expected");
+}
+
+#[test]
+fn output_delimiter_hyphen_help() {
+    new_ucmd!()
+        .args(&["--output-delimiter", "--help", "a", "b"])
+        .succeeds()
+        .stdout_only_fixture("ab_delimiter_hyphen_help.expected");
+}
+
 #[test]
 fn output_delimiter_nul() {
     new_ucmd!()
diff --git a/tests/fixtures/comm/ab_delimiter_hyphen_help.expected b/tests/fixtures/comm/ab_delimiter_hyphen_help.expected
@@ -0,0 +1,3 @@
+a
+--helpb
+--help--helpz
diff --git a/tests/fixtures/comm/ab_delimiter_hyphen_one.expected b/tests/fixtures/comm/ab_delimiter_hyphen_one.expected
@@ -0,0 +1,3 @@
+a
+-1b
+-1-1z

Original file line number	Diff line number	Diff line change
`@@ -186,6 +186,7 @@ pub fn uu_app() -> Command {`
`186`	`186`	`.help("separate columns with STR")`
`187`	`187`	`.value_name("STR")`
`188`	`188`	`.default_value(options::DELIMITER_DEFAULT)`
	`189`	`+ .allow_hyphen_values(true)`
`189`	`190`	`.hide_default_value(true),`
`190`	`191`	`)`
`191`	`192`	`.arg(`