Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

Use pyproject.toml for build dependencies #57

Closed
@rth

Description

@rth

Currently build dependencies are manually specified in CI

NP_BUILD_DEP: "numpy==1.13.3"

That's not ideal, because among other things numpy 1.13.3 does not support python 3.8 yet we are building wheels with it as far as I can tell.

Instead I think we should use the build dependencies from https://github.com/scikit-learn/scikit-learn/blob/master/pyproject.toml to install the correct numpy version depending on the Python version, likely with,

pip wheel . -w dist/

instead of

python setup.py sdist_wheel

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions