Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

Use pyproject.toml for build dependencies #57

Closed
rth opened this issue May 9, 2020 · 1 comment
Closed

Use pyproject.toml for build dependencies #57

rth opened this issue May 9, 2020 · 1 comment

Comments

@rth
Copy link
Contributor

rth commented May 9, 2020

Currently build dependencies are manually specified in CI

scikit-learn-wheels/azure/posix.yml

Line 14 in 1ae7842

NP_BUILD_DEP: "numpy==1.13.3"

That's not ideal, because among other things numpy 1.13.3 does not support python 3.8 yet we are building wheels with it as far as I can tell.

Instead I think we should use the build dependencies from https://github.com/scikit-learn/scikit-learn/blob/master/pyproject.toml to install the correct numpy version depending on the Python version, likely with,

pip wheel . -w dist/

instead of

python setup.py sdist_wheel
@thomasjpfan thomasjpfan mentioned this issue May 10, 2020
Closed
@ogrisel
Copy link
Contributor

ogrisel commented Nov 9, 2020 •
edited
Loading

cibuildwheel already does this:

https://github.com/scikit-learn/scikit-learn/blob/master/.github/workflows/wheels.yml

xref: scikit-learn/scikit-learn#18761

@ogrisel ogrisel closed this as completed Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BLD Uses pyproject.toml build dependencies in posix thomasjpfan/scikit-learn-wheels
2 participants
@ogrisel @rth