Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JavaScriptCodes/loud-links
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: MahdiF/loud-links
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 6 files changed
  • 4 contributors

Commits on Jan 31, 2016

  1. improve performance 

    - hoist variables to top
- cache array.length
- cache document object
- reduce filesize
    @marcobiedermann
    marcobiedermann committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    5fc1ac4 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2016

  1. Merge branch 'marcobiedermann-feature/performance'

    @MahdiF
    MahdiF committed Feb 1, 2016
    Configuration menu
    Copy the full SHA
    30b4f8e View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2016

  1. Grab audioPlayer element on creation 

    No need for grabbing the element by id later, get it from the creation function!
    @shshaw
    shshaw committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    9cce45d View commit details
    Browse the repository at this point in the history

  2. Exit if no audio support 

    No need for all the setup if audio is not supported!
    @shshaw
    shshaw committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    2f48f00 View commit details
    Browse the repository at this point in the history

  3. Rewrite 

    - `data-sound` instead of `data-src` attribute for clarity
- Simplified and combined functions where necessary
- Added the ability to run `loudlinks();` later to support dynamically
added items.
    @shshaw
    shshaw committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    d3f17c4 View commit details
    Browse the repository at this point in the history

  4. No version in file

    @shshaw
    shshaw committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    d94e82f View commit details
    Browse the repository at this point in the history

  5. Version & Attribution

    @shshaw
    shshaw committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    2893cd8 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2016

  1. Merge branch 'shshaw-patch-1'

    @MahdiF
    MahdiF committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    70289a0 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2016

  1. swapped hover events in favor of mouseenter and mouseleave 

    they don't bubble and won't fire the sound for every element's child
    @gibatronic
    gibatronic committed Feb 11, 2016
    Configuration menu
    Copy the full SHA
    34e1f5b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2016

  1. 👓 adding the MIT license

    @MahdiF
    MahdiF committed Feb 14, 2016
    Configuration menu
    Copy the full SHA
    26e31fe View commit details
    Browse the repository at this point in the history

  2. 🐶

    @MahdiF
    MahdiF committed Feb 14, 2016
    Configuration menu
    Copy the full SHA
    a037eca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-hover-event-bubble-issue' of https://github.com/gib… 

    …atronic/loud-links into gibatronic-fix-hover-event-bubble-issue
    @MahdiF
    MahdiF committed Feb 14, 2016
    Configuration menu
    Copy the full SHA
    bdee095 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'gibatronic-fix-hover-event-bubble-issue'

    @MahdiF
    MahdiF committed Feb 14, 2016
    Configuration menu
    Copy the full SHA
    20c2b06 View commit details
    Browse the repository at this point in the history

  5. 💪 V1.2

    @MahdiF
    MahdiF committed Feb 14, 2016
    Configuration menu
    Copy the full SHA
    a51180c View commit details
    Browse the repository at this point in the history

  6. 🙈 I forgot to hide the player

    @MahdiF
    MahdiF committed Feb 14, 2016
    Configuration menu
    Copy the full SHA
    7b4b710 View commit details
    Browse the repository at this point in the history
Loading