Skip to content

Commit 29bb4cf

Browse files
committed
fix page loading failure when no actions
1 parent 39c078c commit 29bb4cf

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

lib/modules/page/task-actions/index.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var handle_actions_1 = require('./handle-actions');
44
var taskPositionTracker = 0;
55
function taskActionsReducer(t, action) {
66
if (t === void 0) { t = []; }
7-
var actions = null;
7+
var actions = [[]];
88
switch (action.type) {
99
case types_1.PAGE_SET:
1010
var _a = action.payload, tasks = _a.tasks, pagePosition = _a.pagePosition, progress = _a.progress;
@@ -14,7 +14,12 @@ function taskActionsReducer(t, action) {
1414
}
1515
else {
1616
actions = tasks.map(function (task) {
17-
return task.actions.filter(function (a) { return !!a.match(/^open/); });
17+
if (task.actions && task.actions.length) {
18+
return task.actions.filter(function (a) { return !!a.match(/^open/); });
19+
}
20+
else {
21+
return [[]];
22+
}
1823
});
1924
}
2025
taskPositionTracker = 0;

src/modules/page/task-actions/index.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ let taskPositionTracker = 0;
77
export default function taskActionsReducer(
88
t = [], action: Action
99
): string[][] {
10-
let actions: string[][] = null;
10+
let actions: string[][] = [[]];
1111
switch (action.type) {
1212

1313
case PAGE_SET:
@@ -21,7 +21,11 @@ export default function taskActionsReducer(
2121
} else {
2222
// filter to only 'open' actions
2323
actions = tasks.map(task => {
24-
return task.actions.filter(a => !!a.match(/^open/));
24+
if (task.actions && task.actions.length) {
25+
return task.actions.filter(a => !!a.match(/^open/));
26+
} else {
27+
return [[]];
28+
}
2529
});
2630
}
2731
// page loads - reset tracker

0 commit comments

Comments
 (0)