unsubscribe from redux store on quit

ShMcK · ShMcK · commit 3993e54fefb0 · 2016-05-08T15:49:06.000-07:00
diff --git a/lib/atom/subscriptions.js b/lib/atom/subscriptions.js
@@ -19,6 +19,7 @@ function onActivate() {
 exports.onActivate = onActivate;
 function onDeactivate() {
     root_1.default.unmount();
+    store_1.default.subscribe(function () { return null; });
     subscriptions.dispose();
 }
 exports.onDeactivate = onDeactivate;
diff --git a/lib/components/root.js b/lib/components/root.js
@@ -8,7 +8,9 @@ var Root = {
         _this.root.setAttribute('id', 'crv');
         return _this.root;
     },
-    unmount: function () { return ReactDOM.unmountComponentAtNode(_this.root); }
+    unmount: function () {
+        ReactDOM.unmountComponentAtNode(_this.root);
+    }
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = Root;
diff --git a/lib/store/index.js b/lib/store/index.js
@@ -2,7 +2,7 @@
 var redux_1 = require('redux');
 var reducers_1 = require('../reducers');
 var createLogger = require('redux-logger');
-var devMode = true;
+var devMode = false;
 var store = null;
 if (devMode) {
     var logger = createLogger();
diff --git a/src/atom/subscriptions.ts b/src/atom/subscriptions.ts
@@ -28,6 +28,8 @@ export function onActivate(): AtomCore.Disposable {
 export function onDeactivate(): void {
   // unmount React
   Root.unmount();
+  // unsubscribe from Redux store
+  store.subscribe(() => null);
   // cleanup subscriptions
   subscriptions.dispose();
 }
diff --git a/src/components/root.ts b/src/components/root.ts
@@ -7,6 +7,8 @@ const Root = {
     this.root.setAttribute('id', 'crv');
     return this.root;
   },
-  unmount: () => ReactDOM.unmountComponentAtNode(this.root)
+  unmount: () => {
+    ReactDOM.unmountComponentAtNode(this.root);
+  }
 };
 export default Root;
diff --git a/src/store/index.ts b/src/store/index.ts
@@ -2,7 +2,7 @@ import { applyMiddleware, createStore } from 'redux';
 import reducer from '../reducers';
 import * as createLogger from 'redux-logger';
 
-const devMode = true;
+const devMode = false;
 let store = null;
 
 if (devMode) {

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ function onActivate() {`
`19`	`19`	`exports.onActivate = onActivate;`
`20`	`20`	`function onDeactivate() {`
`21`	`21`	`root_1.default.unmount();`
	`22`	`+ store_1.default.subscribe(function () { return null; });`
`22`	`23`	`subscriptions.dispose();`
`23`	`24`	`}`
`24`	`25`	`exports.onDeactivate = onDeactivate;`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,8 @@ export function onActivate(): AtomCore.Disposable {`
`28`	`28`	`export function onDeactivate(): void {`
`29`	`29`	`// unmount React`
`30`	`30`	`Root.unmount();`
	`31`	`+ // unsubscribe from Redux store`
	`32`	`+ store.subscribe(() => null);`
`31`	`33`	`// cleanup subscriptions`
`32`	`34`	`subscriptions.dispose();`
`33`	`35`	`}`