Skip to content

Convert Dash-Cased Parameters to CamelCase in getSpaces #76

@MrRefactoring

Description

@MrRefactoring

In the getSpaces function, parameters with a dash (-) are used. The proposal is to replace these dash-cased parameters with camelCase.

The function currently looks like this:

async getSpaces<T = Models.Pagination<Models.Space>>(
  parameters?: Parameters.GetSpaces,
  callback?: Callback<T>,
): Promise<void | T> {
  const config: RequestConfig = {
    url: '/spaces',
    method: 'GET',
    params: {
      ids: parameters?.ids,
      keys: parameters?.keys,
      type: parameters?.type,
      status: parameters?.status,
      labels: parameters?.labels,
      sort: parameters?.sort,
      'description-format': parameters?.['description-format'],
      cursor: parameters?.cursor,
      limit: parameters?.limit,
      'serialize-ids-as-strings': true,
    },
  };

  return this.client.sendRequest(config, callback);
}

Expected function look:

async getSpaces<T = Models.Pagination<Models.Space>>(
  parameters?: Parameters.GetSpaces,
  callback?: Callback<T>,
): Promise<void | T> {
  const config: RequestConfig = {
    url: '/spaces',
    method: 'GET',
    params: {
      ids: parameters?.ids,
      keys: parameters?.keys,
      type: parameters?.type,
      status: parameters?.status,
      labels: parameters?.labels,
      sort: parameters?.sort,
      'description-format': parameters?.descriptionFormat,
      cursor: parameters?.cursor,
      limit: parameters?.limit,
      'serialize-ids-as-strings': true,
    },
  };

  return this.client.sendRequest(config, callback);
}

Metadata

Metadata

Assignees

Labels

enhancementDenotes a suggestion or request aimed at improving or adding new features to the projectgood first issueHighlights beginner-friendly tasks, ideal for those looking to contribute for the first timehelp wantedSignals that additional assistance or expertise is needed on a particular issue or feature

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions