fix(core): remove redundant event name splitting

shirakaba · shirakaba · commit 63115923b8e5 · 2024-05-02T08:41:05.000+09:00
ViewCommon splits event names redundantly (the superclass, Observable, splits event names too).
diff --git a/packages/core/ui/core/view/view-common.ts b/packages/core/ui/core/view/view-common.ts
@@ -33,8 +33,6 @@ import { SharedTransition, SharedTransitionInteractiveOptions } from '../../tran
 // helpers (these are okay re-exported here)
 export * from './view-helper';
 
-const eventNamesRegex = /\s*,\s*/;
-
 let animationModule: typeof am;
 function ensureAnimationModule() {
 	if (!animationModule) {
@@ -311,9 +309,7 @@ export abstract class ViewCommon extends ViewBase implements ViewDefinition {
 			return;
 		}
 
-		for (const eventName of normalizedName.trim().split(eventNamesRegex)) {
-			super.addEventListener(eventName, callback, thisArg);
-		}
+		super.addEventListener(normalizedName, callback, thisArg);
 	}
 
 	public removeEventListener(arg: string | GestureTypes, callback?: (data: EventData) => void, thisArg?: any) {
@@ -335,9 +331,7 @@ export abstract class ViewCommon extends ViewBase implements ViewDefinition {
 			return;
 		}
 
-		for (const eventName of normalizedName.trim().split(eventNamesRegex)) {
-			super.removeEventListener(eventName, callback, thisArg);
-		}
+		super.removeEventListener(normalizedName, callback, thisArg);
 	}
 
 	public onBackPressed(): boolean {

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,6 @@ import { SharedTransition, SharedTransitionInteractiveOptions } from '../../tran`
`33`	`33`	`// helpers (these are okay re-exported here)`
`34`	`34`	`export * from './view-helper';`
`35`	`35`
`36`		`-const eventNamesRegex = /\s,\s/;`
`37`		`-`
`38`	`36`	`let animationModule: typeof am;`
`39`	`37`	`function ensureAnimationModule() {`
`40`	`38`	`if (!animationModule) {`
`@@ -311,9 +309,7 @@ export abstract class ViewCommon extends ViewBase implements ViewDefinition {`
`311`	`309`	`return;`
`312`	`310`	`}`
`313`	`311`
`314`		`- for (const eventName of normalizedName.trim().split(eventNamesRegex)) {`
`315`		`- super.addEventListener(eventName, callback, thisArg);`
`316`		`- }`
	`312`	`+ super.addEventListener(normalizedName, callback, thisArg);`
`317`	`313`	`}`
`318`	`314`
`319`	`315`	`public removeEventListener(arg: string \| GestureTypes, callback?: (data: EventData) => void, thisArg?: any) {`
`@@ -335,9 +331,7 @@ export abstract class ViewCommon extends ViewBase implements ViewDefinition {`
`335`	`331`	`return;`
`336`	`332`	`}`
`337`	`333`
`338`		`- for (const eventName of normalizedName.trim().split(eventNamesRegex)) {`
`339`		`- super.removeEventListener(eventName, callback, thisArg);`
`340`		`- }`
	`334`	`+ super.removeEventListener(normalizedName, callback, thisArg);`
`341`	`335`	`}`
`342`	`336`
`343`	`337`	`public onBackPressed(): boolean {`