Skip to content

Commit 750d2ee

Browse files
authored
fix(core): frame ignored event listeners in xml markup (#10646)
1 parent 712a9f4 commit 750d2ee

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

packages/core/ui/frame/frame-common.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ function buildEntryFromArgs(arg: any): NavigationEntry {
3535

3636
@CSSType('Frame')
3737
export class FrameBase extends CustomLayoutView {
38-
public static androidOptionSelectedEvent = 'optionSelected';
38+
public static navigatingToEvent = 'navigatingTo';
39+
public static navigatedToEvent = 'navigatedTo';
3940

4041
private _animated: boolean;
4142
private _transition: NavigationTransition;
@@ -267,7 +268,7 @@ export class FrameBase extends CustomLayoutView {
267268

268269
newPage.onNavigatedTo(isBack);
269270
this.notify({
270-
eventName: Page.navigatedToEvent,
271+
eventName: FrameBase.navigatedToEvent,
271272
object: this,
272273
isBack,
273274
entry,
@@ -452,7 +453,7 @@ export class FrameBase extends CustomLayoutView {
452453

453454
backstackEntry.resolvedPage.onNavigatingTo(backstackEntry.entry.context, isBack, backstackEntry.entry.bindingContext);
454455
this.notify({
455-
eventName: Page.navigatingToEvent,
456+
eventName: FrameBase.navigatingToEvent,
456457
object: this,
457458
isBack,
458459
entry: backstackEntry,

packages/core/ui/frame/index.d.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,16 @@ export interface NavigationData extends EventData {
1717
* Nested frames are supported, enabling hierarchical navigation scenarios.
1818
*/
1919
export class Frame extends FrameBase {
20+
/**
21+
* String value used when hooking to navigatingTo event.
22+
*/
23+
public static readonly navigatingToEvent = 'navigatingTo';
24+
25+
/**
26+
* String value used when hooking to navigatedTo event.
27+
*/
28+
public static readonly navigatedToEvent = 'navigatedTo';
29+
2030
/**
2131
* @private
2232
*/

0 commit comments

Comments
 (0)