push changes

ammarahm-ed · ammarahm-ed · commit 84b648dba7e4 · 2023-05-26T16:02:47.000+05:00
diff --git a/packages/core/ui/core/dom/src/nodes/document-fragment/DocumentFragment.ts b/packages/core/ui/core/dom/src/nodes/document-fragment/DocumentFragment.ts
@@ -8,6 +8,12 @@ export default class DocumentFragment extends ParentNode {
 	public nodeName: string = '#document-fragment';
 	public localName: string = '#document-fragment';
 	isParentNode = true;
+	// Set this to true if you want the
+	// children of this fragment to render.
+	// By default  native counerparts of the
+	// elements inside a DocumentFragement are
+	// not created.
+	canRender = false;
 	constructor() {
 		super();
 		this._rootNode = this;
diff --git a/packages/core/ui/core/dom/src/nodes/element/Element.ts b/packages/core/ui/core/dom/src/nodes/element/Element.ts
@@ -391,8 +391,11 @@ export default class Element extends ParentNode {
 const updateAttributeNS = (self: Element, namespace: string, name: string, value: any) => {
 	let attr = findWhere(self.attributes, createAttributeFilter(namespace, name), false, false);
 	if (!attr) self.attributes.push((attr = { namespaceURI: namespace, name } as IAttr));
-
 	if (attr.value === value) return;
+	attr.value = value;
+	if (self.canRender && self['isNativeElement']) {
+		self[name] = value;
+	}
 
 	if (self.attributeChangedCallback && (<typeof Element>self.constructor)._observedAttributes && (<typeof Element>self.constructor)._observedAttributes.includes(name)) {
 		self.attributeChangedCallback(name, attr.value, value);
diff --git a/packages/core/ui/core/dom/src/nodes/node/Node.ts b/packages/core/ui/core/dom/src/nodes/node/Node.ts
@@ -211,6 +211,7 @@ export default class Node extends Observable {
 			else this.firstChild = newNode;
 		}
 		assignParentNode(newNode);
+		newNode['canRender'] = this.canRender;
 		if (newNode.connectedCallback) newNode.connectedCallback();
 		return newNode;
 	}
@@ -250,6 +251,7 @@ export default class Node extends Observable {
 		node._rootNode = null;
 		if (node.disconnectedCallback) node.disconnectedCallback();
 		assignParentNode(node);
+		node.canRender = true;
 		return node;
 	}
 
diff --git a/packages/core/ui/core/dom/src/xml-parser/XMLParser.ts b/packages/core/ui/core/dom/src/xml-parser/XMLParser.ts
@@ -236,6 +236,6 @@ export default class XMLParser {
 		if (namespaceURI === NamespaceURI.svg) {
 			return name;
 		}
-		return name.toLowerCase();
+		return name;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -211,6 +211,7 @@ export default class Node extends Observable {`
`211`	`211`	`else this.firstChild = newNode;`
`212`	`212`	`}`
`213`	`213`	`assignParentNode(newNode);`
	`214`	`+ newNode['canRender'] = this.canRender;`
`214`	`215`	`if (newNode.connectedCallback) newNode.connectedCallback();`
`215`	`216`	`return newNode;`
`216`	`217`	`}`
`@@ -250,6 +251,7 @@ export default class Node extends Observable {`
`250`	`251`	`node._rootNode = null;`
`251`	`252`	`if (node.disconnectedCallback) node.disconnectedCallback();`
`252`	`253`	`assignParentNode(node);`
	`254`	`+ node.canRender = true;`
`253`	`255`	`return node;`
`254`	`256`	`}`
`255`	`257`
Original file line number	Diff line number	Diff line change
`@@ -236,6 +236,6 @@ export default class XMLParser {`
`236`	`236`	`if (namespaceURI === NamespaceURI.svg) {`
`237`	`237`	`return name;`
`238`	`238`	`}`
`239`		`- return name.toLowerCase();`
	`239`	`+ return name;`
`240`	`240`	`}`
`241`	`241`	`}`