refactor: Application barrel changes without breaking changes (#10311)

NathanWalker · web-flow · commit ab5fa941bc93 · 2023-06-13T09:29:39.000-07:00
diff --git a/apps/automated/src/application/application-tests.android.ts b/apps/automated/src/application/application-tests.android.ts
@@ -1,5 +1,5 @@
 /* tslint:disable:no-unused-variable */
-import { Application } from '@nativescript/core';
+import { Application, Utils } from '@nativescript/core';
 import * as TKUnit from '../tk-unit';
 
 export * from './application-tests-common';
@@ -47,11 +47,11 @@ export function testAndroidApplicationInitialized() {
 	);
 	TKUnit.assert(Application.android.startActivity, 'Android startActivity not initialized.');
 	TKUnit.assert(Application.android.nativeApp, 'Android nativeApp not initialized.');
-	TKUnit.assert(Application.android.orientation, 'Android orientation not initialized.');
-	TKUnit.assert(Application.android.packageName, 'Android packageName not initialized.');
-	TKUnit.assert(Application.android.systemAppearance, 'Android system appearance not initialized.');
+	TKUnit.assert(Application.android.orientation(), 'Android orientation not initialized.');
+	TKUnit.assert(Utils.android.getPackageName(), 'Android packageName not initialized.');
+	TKUnit.assert(Application.android.systemAppearance(), 'Android system appearance not initialized.');
 }
 
 export function testSystemAppearance() {
-	TKUnit.assert(Application.android.systemAppearance, 'System appearance not initialized.');
+	TKUnit.assert(Application.android.systemAppearance(), 'System appearance not initialized.');
 }
diff --git a/apps/automated/src/application/application-tests.ios.ts b/apps/automated/src/application/application-tests.ios.ts
@@ -44,12 +44,12 @@ export function testIOSApplicationInitialized() {
 	TKUnit.assert(Application.ios, 'iOS application not initialized.');
 	TKUnit.assert(Application.ios.delegate, 'iOS delegate not initialized.');
 	TKUnit.assert(Application.ios.nativeApp, 'iOS nativeApp not initialized.');
-	TKUnit.assert(Application.ios.orientation, 'iOS orientation not initialized.');
+	TKUnit.assert(Application.ios.orientation(), 'iOS orientation not initialized.');
 
 	if (Utils.ios.MajorVersion <= 11) {
-		TKUnit.assertNull(Application.ios.systemAppearance, 'iOS system appearance should be `null` on iOS <= 11.');
+		TKUnit.assertNull(Application.ios.systemAppearance(), 'iOS system appearance should be `null` on iOS <= 11.');
 	} else {
-		TKUnit.assert(Application.ios.systemAppearance, 'iOS system appearance not initialized.');
+		TKUnit.assert(Application.ios.systemAppearance(), 'iOS system appearance not initialized.');
 	}
 
 	TKUnit.assert(Application.ios.window, 'iOS window not initialized.');
@@ -58,8 +58,8 @@ export function testIOSApplicationInitialized() {
 
 export function testSystemAppearance() {
 	if (Utils.ios.MajorVersion <= 11) {
-		TKUnit.assertNull(Application.ios.systemAppearance, 'System appearance should be `null` on iOS <= 11.');
+		TKUnit.assertNull(Application.ios.systemAppearance(), 'System appearance should be `null` on iOS <= 11.');
 	} else {
-		TKUnit.assert(Application.ios.systemAppearance, 'System appearance not initialized.');
+		TKUnit.assert(Application.ios.systemAppearance(), 'System appearance not initialized.');
 	}
 }
diff --git a/packages/core/application/application-common.ts b/packages/core/application/application-common.ts
@@ -438,7 +438,7 @@ export class ApplicationCommon {
 		});
 	}
 
-	get orientation(): 'portrait' | 'landscape' | 'unknown' {
+	orientation(): 'portrait' | 'landscape' | 'unknown' {
 		return (this._orientation ??= this.getOrientation());
 	}
 
@@ -487,7 +487,7 @@ export class ApplicationCommon {
 		});
 	}
 
-	get systemAppearance(): 'dark' | 'light' | null {
+	systemAppearance(): 'dark' | 'light' | null {
 		// return cached value, or get it from the platform specific override
 		return (this._systemAppearance ??= this.getSystemAppearance());
 	}
diff --git a/packages/core/application/application-shims.ts b/packages/core/application/application-shims.ts

Original file line number	Diff line number	Diff line change
`@@ -438,7 +438,7 @@ export class ApplicationCommon {`
`438`	`438`	`});`
`439`	`439`	`}`
`440`	`440`
`441`		`- get orientation(): 'portrait' \| 'landscape' \| 'unknown' {`
	`441`	`+ orientation(): 'portrait' \| 'landscape' \| 'unknown' {`
`442`	`442`	`return (this._orientation ??= this.getOrientation());`
`443`	`443`	`}`
`444`	`444`
`@@ -487,7 +487,7 @@ export class ApplicationCommon {`
`487`	`487`	`});`
`488`	`488`	`}`
`489`	`489`
`490`		`- get systemAppearance(): 'dark' \| 'light' \| null {`
	`490`	`+ systemAppearance(): 'dark' \| 'light' \| null {`
`491`	`491`	`// return cached value, or get it from the platform specific override`
`492`	`492`	`return (this._systemAppearance ??= this.getSystemAppearance());`
`493`	`493`	`}`