fix: Use FormattedString background color as fallback

CatchABus · CatchABus · commit b12c28db5782 · 2025-02-20T14:44:05.000+02:00
diff --git a/packages/core/ui/text-base/index.android.ts b/packages/core/ui/text-base/index.android.ts
@@ -624,8 +624,10 @@ function setSpanModifiers(ssb: android.text.SpannableStringBuilder, span: Span,
 		ssb.setSpan(new android.text.style.ForegroundColorSpan(color.android), start, end, android.text.Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
 	}
 
-	if (spanStyle.backgroundColor) {
-		ssb.setSpan(new android.text.style.BackgroundColorSpan(spanStyle.backgroundColor.android), start, end, android.text.Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
+	// Use span or formatted string color
+	const backgroundColor = spanStyle.backgroundColor || span.parent.backgroundColor;
+	if (backgroundColor) {
+		ssb.setSpan(new android.text.style.BackgroundColorSpan(backgroundColor.android), start, end, android.text.Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
 	}
 
 	const textDecoration: CoreTypes.TextDecorationType = getClosestPropertyValue(textDecorationProperty, span);
diff --git a/packages/core/ui/text-base/index.ios.ts b/packages/core/ui/text-base/index.ios.ts
@@ -394,7 +394,8 @@ export class TextBase extends TextBaseCommon {
 		const fontScale = adjustMinMaxFontScale(span.style.fontScaleInternal, span);
 		const font = new Font(span.style.fontFamily, span.style.fontSize, span.style.fontStyle, span.style.fontWeight, fontScale, span.style.fontVariationSettings);
 		const iosFont = font.getUIFont(this.nativeTextViewProtected.font);
-		const backgroundColor = span.style.backgroundColor;
+		// Use span or formatted string color
+		const backgroundColor = span.style.backgroundColor || span.parent.backgroundColor;
 
 		return {
 			text,
diff --git a/packages/core/ui/text-base/span.d.ts b/packages/core/ui/text-base/span.d.ts
@@ -2,13 +2,16 @@
 import { ViewBase } from '../core/view-base';
 import { FontStyleType, FontVariationSettingsType, FontWeightType } from '../styling/font';
 import { CoreTypes } from '../../core-types';
+import { FormattedString } from './formatted-string';
 
 /**
  * A class used to create a single part of formatted string with a common text properties.
  *
  * @nsView Span
  */
 export class Span extends ViewBase {
+	declare parent: FormattedString;
+
 	/**
 	 * Gets or sets the font family of the span.
 	 *
diff --git a/packages/core/ui/text-base/span.ts b/packages/core/ui/text-base/span.ts
@@ -5,12 +5,16 @@ import { FontStyleType, FontVariationSettingsType, FontWeightType } from '../sty
 import { CoreTypes } from '../../core-types';
 import { EventData } from '../../data/observable';
 import { isNullOrUndefined, isString } from '../../utils/types';
+import type { FormattedString } from './formatted-string';
 
 export class Span extends ViewBase implements SpanDefinition {
-	static linkTapEvent = 'linkTap';
+	public static linkTapEvent = 'linkTap';
+
 	private _text: string;
 	private _tappable = false;
 
+	declare parent: FormattedString;
+
 	get fontFamily(): string {
 		return this.style.fontFamily;
 	}

Original file line number	Diff line number	Diff line change
`@@ -624,8 +624,10 @@ function setSpanModifiers(ssb: android.text.SpannableStringBuilder, span: Span,`
`624`	`624`	`ssb.setSpan(new android.text.style.ForegroundColorSpan(color.android), start, end, android.text.Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);`
`625`	`625`	`}`
`626`	`626`
`627`		`- if (spanStyle.backgroundColor) {`
`628`		`- ssb.setSpan(new android.text.style.BackgroundColorSpan(spanStyle.backgroundColor.android), start, end, android.text.Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);`
	`627`	`+ // Use span or formatted string color`
	`628`	`+ const backgroundColor = spanStyle.backgroundColor \|\| span.parent.backgroundColor;`
	`629`	`+ if (backgroundColor) {`
	`630`	`+ ssb.setSpan(new android.text.style.BackgroundColorSpan(backgroundColor.android), start, end, android.text.Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);`
`629`	`631`	`}`
`630`	`632`
`631`	`633`	`const textDecoration: CoreTypes.TextDecorationType = getClosestPropertyValue(textDecorationProperty, span);`