feat(core): new autoFillTypes for newUsername, newPassword and oneTimeCode (#10159)

farfromrefug · web-flow · commit bff35e5163d1 · 2023-01-09T09:38:28.000-08:00
diff --git a/packages/core/core-types/index.ts b/packages/core/core-types/index.ts
@@ -50,6 +50,9 @@ export namespace CoreTypes {
 	export module AutofillType {
 		export const username = 'username';
 		export const password = 'password';
+		export const newUsername = 'newUsername';
+		export const newPassword = 'newPassword';
+		export const oneTimeCode = 'oneTimeCode';
 		export const none = 'none';
 	}
 
diff --git a/packages/core/ui/editable-text-base/index.android.ts b/packages/core/ui/editable-text-base/index.android.ts
@@ -269,6 +269,15 @@ export abstract class EditableTextBase extends EditableTextBaseCommon {
 			case 'password':
 				newOptions = 'password'; // android.view.View.AUTOFILL_HINT_PASSWORD
 				break;
+			case 'newPassword':
+				newOptions = 'newPassword'; // android.view.View.AUTOFILL_HINT_NEW_PASSWORD
+				break;
+			case 'newUsername':
+				newOptions = 'newUsername'; // android.view.View.AUTOFILL_HINT_NEW_USERNAME
+				break;
+			case 'oneTimeCode':
+				newOptions = '2faAppOTPCode'; // android.view.View.AUTOFILL_HINT_2FA_APP_OTP
+				break;
 			case 'none':
 				newOptions = null;
 				break;
diff --git a/packages/core/ui/editable-text-base/index.ios.ts b/packages/core/ui/editable-text-base/index.ios.ts
@@ -96,6 +96,12 @@ export abstract class EditableTextBase extends EditableTextBaseCommon {
 			case 'password':
 				newTextContentType = UITextContentTypePassword;
 				break;
+			case 'newPassword':
+				newTextContentType = UITextContentTypeNewPassword;
+				break;
+			case 'oneTimeCode':
+				newTextContentType = UITextContentTypeOneTimeCode;
+				break;
 			case 'none':
 				newTextContentType = null;
 			default:

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@ export namespace CoreTypes {`
`50`	`50`	`export module AutofillType {`
`51`	`51`	`export const username = 'username';`
`52`	`52`	`export const password = 'password';`
	`53`	`+ export const newUsername = 'newUsername';`
	`54`	`+ export const newPassword = 'newPassword';`
	`55`	`+ export const oneTimeCode = 'oneTimeCode';`
`53`	`56`	`export const none = 'none';`
`54`	`57`	`}`
`55`	`58`