fix(ios): memory leak after using the 'presentViewControllerNavigation' (#9934)

dgmachado · web-flow · commit edc2e6a5de3a · 2022-06-16T13:30:28.000-07:00
diff --git a/packages/core/ui/core/view/index.ios.ts b/packages/core/ui/core/view/index.ios.ts
@@ -543,6 +543,7 @@ export class View extends ViewCommon implements ViewDefinition {
 			// Take a look at https://github.com/NativeScript/NativeScript/issues/2173 for more info and a sample project.
 			this._raiseShownModallyEvent();
 		}
+		controller = null;
 	}
 
 	protected _hideNativeModalView(parent: View, whenClosedCallback: () => void) {
diff --git a/packages/core/ui/frame/index.ios.ts b/packages/core/ui/frame/index.ios.ts
@@ -42,6 +42,8 @@ export class Frame extends FrameBase {
 		this._removeFromFrameStack();
 		this.viewController = null;
 		this._ios.controller = null;
+		this._animatedDelegate = null;
+		this._ios = null;
 		super.disposeNativeView();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -543,6 +543,7 @@ export class View extends ViewCommon implements ViewDefinition {`
`543`	`543`	`// Take a look at https://github.com/NativeScript/NativeScript/issues/2173 for more info and a sample project.`
`544`	`544`	`this._raiseShownModallyEvent();`
`545`	`545`	`}`
	`546`	`+ controller = null;`
`546`	`547`	`}`
`547`	`548`
`548`	`549`	`protected _hideNativeModalView(parent: View, whenClosedCallback: () => void) {`
Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,8 @@ export class Frame extends FrameBase {`
`42`	`42`	`this._removeFromFrameStack();`
`43`	`43`	`this.viewController = null;`
`44`	`44`	`this._ios.controller = null;`
	`45`	`+ this._animatedDelegate = null;`
	`46`	`+ this._ios = null;`
`45`	`47`	`super.disposeNativeView();`
`46`	`48`	`}`
`47`	`49`