Skip to content

Allow opting out of iosOverflowSafeArea being true by default #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lsapan opened this issue Nov 17, 2018 · 3 comments · Fixed by #6656
Closed

Allow opting out of iosOverflowSafeArea being true by default #6573

lsapan opened this issue Nov 17, 2018 · 3 comments · Fixed by #6656
Labels
needs more info

Comments

@lsapan
Copy link

lsapan commented Nov 17, 2018

Is your feature request related to a problem? Please describe.
Built-in support for iOS safe area is awesome! However, I'm finding that I need to add iosOverflowSafeArea="false" everywhere now. I typically use nested StackLayout components where I would use a div in HTML. They're also great for laying out items horizontally instead of vertically, etc. The problem is that these components are not being used as containers, but simply nested layouts. Obviously NativeScript doesn't know this, so it's adding crazy padding to all of these nested elements on iPhone X, XS, etc.

Describe the solution you'd like
Add an option to make iosOverflowSafeArea false by default. This would allow users to manually set it to true on actual container elements.

Describe alternatives you've considered
This just also naturally makes me wonder if I've been tackling NativeScript development wrong. If users aren't using nested layouts, what are they using? Is there something else I should be doing that I'm not aware of?
@tsonevn
Copy link
Contributor

tsonevn commented Nov 19, 2018

Hi @lsapan,
Can you give us some more info about your case? It will help if you provide a sample project or at least some code fragments, which shows the issue you are facing.
Some issue with the iosOverflowSafeArea property and the ScrollView has been fixed with PR - #6561. The PR is already merged in master, and I would suggest testing with @next(tns plugin remove tns-core-modules->tns plugin add tns-core-modules@next) modules and check if you will have the same problem.

@tsonevn
Copy link
Contributor

tsonevn commented Dec 4, 2018

closing due to inactivity

@tsonevn tsonevn closed this as completed Dec 4, 2018
@MartoYankov MartoYankov reopened this Dec 5, 2018
@MartoYankov MartoYankov self-assigned this Dec 5, 2018
@MartoYankov MartoYankov mentioned this issue Dec 5, 2018
Merged
@lock
Copy link

lock bot commented Dec 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot unassigned MartoYankov Dec 5, 2019
@lock lock bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs more info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(listview-ios): incorrect layout when scroll NativeScript/NativeScript
3 participants
@lsapan @MartoYankov @tsonevn