From d53ca55c4398b7a747e240062becebbeaade8084 Mon Sep 17 00:00:00 2001
From: farfromrefuge <martin.guillon@akylas.fr>
Date: Wed, 29 May 2024 14:12:20 +0200
Subject: [PATCH] fix: prevent breaking modal stack

Using splice without second parameter was removing all elements after first argument index.
This would break if a modal was closed just after opening a second one
---
 packages/core/ui/core/view/view-common.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/core/ui/core/view/view-common.ts b/packages/core/ui/core/view/view-common.ts
index 6b68d42cc9..7b7561465d 100644
--- a/packages/core/ui/core/view/view-common.ts
+++ b/packages/core/ui/core/view/view-common.ts
@@ -419,7 +419,7 @@ export abstract class ViewCommon extends ViewBase implements ViewDefinition {
 		this._closeModalCallback = (...originalArgs) => {
 			const cleanupModalViews = () => {
 				const modalIndex = _rootModalViews.indexOf(this);
-				_rootModalViews.splice(modalIndex);
+				_rootModalViews.splice(modalIndex, 1);
 				this._modalParent = null;
 				this._modalContext = null;
 				this._closeModalCallback = null;