fix(core): Avoid splicing arrays using a negative start index #10679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There are cases when core splices arrays using a negative index.
This can have bad consequences as
splice
negative index counts back from the end of the array.For example, calling
LayoutBase.removeChild
to remove a view that is not an actual child will unexpectedly remove an existing child from the caller layout.What is the new behavior?
Added index checking for 4 array splice calls that were error-prone.