refactor: reset css property value when ''" (empty string) is set #5085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanayotCankov
suggested changes
Nov 22, 2017
| @@ -1049,6 +1050,9 @@ export class ShorthandProperty<T extends Style, P> implements definitions.Shorth | |||
| } | |||
| } | |||
|
|
|||
| const shouldResetCssProperty = value => | |||
c1bf8cd to
a30600b
Compare
PanayotCankov
suggested changes
Nov 22, 2017
| @@ -534,7 +535,8 @@ export class CssProperty<T extends Style, U> implements definitions.CssProperty< | |||
| } | |||
|
|
|||
| function setCssValue(this: T, value: U): void { | |||
| const reset = value === unsetValue; | |||
| const reset = value === unsetValue || | |||
| typeof value === "string" && value === ""; | |||
There was a problem hiding this comment.
value === "" should suffice
There was a problem hiding this comment.
value is of type U. I can't be even explicitly casted to <string>. Should I cast it to <any>?
PanayotCankov
approved these changes
Nov 23, 2017
PanayotCankov
approved these changes
Nov 23, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.