feat: migrate nx to latest beta and angular to 17

edusperoni · edusperoni · commit 2db5cd71ccb8 · 2023-11-08T15:01:44.000-03:00
diff --git a/nx.json b/nx.json
@@ -29,8 +29,18 @@
       "inputs": ["default", "{workspaceRoot}/.eslintrc.json"],
       "cache": true
     },
-    "e2e": {
-      "cache": true
+    "@nx/jest:jest": {
+      "inputs": ["default", "^production", "{workspaceRoot}/jest.preset.js"],
+      "cache": true,
+      "options": {
+        "passWithNoTests": true
+      },
+      "configurations": {
+        "ci": {
+          "ci": true,
+          "codeCoverage": true
+        }
+      }
     }
   },
   "namedInputs": {
diff --git a/package.json b/package.json
@@ -35,29 +35,29 @@
     "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s"
   },
   "dependencies": {
-    "@angular/animations": "17.0.0-rc.2",
-    "@angular/common": "17.0.0-rc.2",
-    "@angular/compiler": "17.0.0-rc.2",
-    "@angular/core": "17.0.0-rc.2",
-    "@angular/forms": "17.0.0-rc.2",
-    "@angular/platform-browser": "17.0.0-rc.2",
-    "@angular/platform-browser-dynamic": "17.0.0-rc.2",
-    "@angular/router": "17.0.0-rc.2",
+    "@angular/animations": "17.0.0",
+    "@angular/common": "17.0.0",
+    "@angular/compiler": "17.0.0",
+    "@angular/core": "17.0.0",
+    "@angular/forms": "17.0.0",
+    "@angular/platform-browser": "17.0.0",
+    "@angular/platform-browser-dynamic": "17.0.0",
+    "@angular/router": "17.0.0",
     "@nativescript/core": "~8.6.0",
     "@nativescript/theme": "~3.0.2",
     "@ngx-translate/core": "~15.0.0",
     "nativescript-fonticon": "~8.0.0",
     "rxjs": "^7.8.0",
-    "zone.js": "0.13.1"
+    "zone.js": "0.14.2"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "17.0.0-rc.3",
-    "@angular-devkit/core": "17.0.0-rc.3",
-    "@angular-devkit/schematics": "17.0.0-rc.3",
-    "@angular-eslint/eslint-plugin": "16.2.0",
-    "@angular-eslint/eslint-plugin-template": "16.2.0",
-    "@angular-eslint/template-parser": "16.2.0",
-    "@angular/compiler-cli": "17.0.0-rc.2",
+    "@angular-devkit/build-angular": "17.0.0",
+    "@angular-devkit/core": "17.0.0",
+    "@angular-devkit/schematics": "17.0.0",
+    "@angular-eslint/eslint-plugin": "17.0.0",
+    "@angular-eslint/eslint-plugin-template": "17.0.0",
+    "@angular-eslint/template-parser": "17.0.0",
+    "@angular/compiler-cli": "17.0.0",
     "@jsdevtools/coverage-istanbul-loader": "3.0.5",
     "@nativescript/types": "~8.6.0",
     "@nativescript/unit-test-runner": "^3.0.4",
@@ -67,20 +67,20 @@
     "@nstudio/nativescript": "17.0.1",
     "@nstudio/nativescript-angular": "17.0.1",
     "@nstudio/xplat": "17.0.1",
-    "@nx/angular": "17.0.3",
-    "@nx/eslint": "17.0.3",
-    "@nx/eslint-plugin": "17.0.3",
-    "@nx/jest": "17.0.3",
-    "@nx/js": "17.0.3",
-    "@nx/node": "17.0.3",
-    "@nx/workspace": "17.0.3",
-    "@schematics/angular": "17.0.0-rc.3",
+    "@nx/angular": "17.1.0-beta.4",
+    "@nx/eslint": "17.1.0-beta.4",
+    "@nx/eslint-plugin": "17.1.0-beta.4",
+    "@nx/jest": "17.1.0-beta.4",
+    "@nx/js": "17.1.0-beta.4",
+    "@nx/node": "17.1.0-beta.4",
+    "@nx/workspace": "17.1.0-beta.4",
+    "@schematics/angular": "17.0.0",
     "@types/jasmine": "5.1.1",
     "@types/jest": "29.5.7",
     "@types/node": "^20.0.0",
     "@types/sinon": "^17.0.0",
-    "@typescript-eslint/eslint-plugin": "6.9.1",
-    "@typescript-eslint/parser": "6.9.1",
+    "@typescript-eslint/eslint-plugin": "6.10.0",
+    "@typescript-eslint/parser": "6.10.0",
     "conventional-changelog-cli": "^4.1.0",
     "dotenv": "16.3.1",
     "eslint": "8.53.0",
@@ -96,8 +96,8 @@
     "karma-nativescript-launcher": "0.4.0",
     "karma-sinon": "^1.0.5",
     "lint-staged": "^15.0.0",
-    "ng-packagr": "17.0.0-rc.1",
-    "nx": "17.0.3",
+    "ng-packagr": "17.0.0",
+    "nx": "17.1.0-beta.4",
     "nyc": "15.1.0",
     "postcss": "^8.4.16",
     "postcss-import": "15.1.0",
diff --git a/packages/angular/project.json b/packages/angular/project.json
@@ -21,8 +21,7 @@
     "test": {
       "executor": "@nx/jest:jest",
       "options": {
-        "jestConfig": "packages/angular/jest.config.ts",
-        "passWithNoTests": true
+        "jestConfig": "packages/angular/jest.config.ts"
       },
       "outputs": ["{workspaceRoot}/coverage/packages/angular"]
     }
diff --git a/packages/zone-js/.eslintrc.json b/packages/zone-js/.eslintrc.json
@@ -9,7 +9,9 @@
     },
     {
       "files": ["*.ts", "*.tsx"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-explicit-any": "warn"
+      }
     },
     {
       "files": ["*.js", "*.jsx"],
diff --git a/packages/zone-js/project.json b/packages/zone-js/project.json
@@ -24,8 +24,7 @@
       "executor": "@nx/jest:jest",
       "outputs": ["{workspaceRoot}/coverage/packages/zone-js"],
       "options": {
-        "jestConfig": "packages/zone-js/jest.config.ts",
-        "passWithNoTests": true
+        "jestConfig": "packages/zone-js/jest.config.ts"
       }
     }
   },
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,9 @@`
`9`	`9`	`},`
`10`	`10`	`{`
`11`	`11`	`"files": [".ts", ".tsx"],`
`12`		`- "rules": {}`
	`12`	`+ "rules": {`
	`13`	`+ "@typescript-eslint/no-explicit-any": "warn"`
	`14`	`+ }`
`13`	`15`	`},`
`14`	`16`	`{`
`15`	`17`	`"files": [".js", ".jsx"],`
Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,7 @@`
`24`	`24`	`"executor": "@nx/jest:jest",`
`25`	`25`	`"outputs": ["{workspaceRoot}/coverage/packages/zone-js"],`
`26`	`26`	`"options": {`
`27`		`- "jestConfig": "packages/zone-js/jest.config.ts",`
`28`		`- "passWithNoTests": true`
	`27`	`+ "jestConfig": "packages/zone-js/jest.config.ts"`
`29`	`28`	`}`
`30`	`29`	`}`
`31`	`30`	`},`