chore: fix demo linting

edusperoni · edusperoni · commit 559a20e1870f · 2023-11-08T13:48:33.000-03:00
diff --git a/apps/nativescript-demo-ng/.eslintrc.json b/apps/nativescript-demo-ng/.eslintrc.json
@@ -24,7 +24,9 @@
             "prefix": "",
             "style": "kebab-case"
           }
-        ]
+        ],
+        "@typescript-eslint/no-explicit-any": "warn",
+        "@typescript-eslint/no-unused-vars": "warn"
       }
     },
     {
diff --git a/apps/nativescript-demo-ng/src/app/app-routing.module.ts b/apps/nativescript-demo-ng/src/app/app-routing.module.ts
@@ -1,9 +1,9 @@
 import { NgModule } from '@angular/core';
-import { NativeScriptRouterModule, NSEmptyOutletComponent } from '@nativescript/angular';
 import { Routes } from '@angular/router';
+import { NativeScriptRouterModule } from '@nativescript/angular';
 
-import { ItemsComponent } from './item/items.component';
 import { ItemDetailComponent } from './item/item-detail.component';
+import { ItemsComponent } from './item/items.component';
 // import { HomeComponent } from './home/home.component';
 // import { BootGuardService } from './boot-guard.service';
 
@@ -21,7 +21,7 @@ const routes: Routes = [
   // {
   //   path: 'home',
   //   component: HomeComponent,
-  //   canActivate: [BootGuardService],
+  //   canActivate: [() => Promise.resolve(true)],
   //   children: [
   //     {
   //       path: 'start',
diff --git a/apps/nativescript-demo-ng/src/app/app.module.ts b/apps/nativescript-demo-ng/src/app/app.module.ts
@@ -1,10 +1,10 @@
 import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
-import { NativeScriptModule, NativeScriptCommonModule, NativeScriptHttpClientModule, NativeDialogModule } from '@nativescript/angular';
+import { NativeDialogModule, NativeScriptHttpClientModule, NativeScriptModule } from '@nativescript/angular';
 
 import { AppRoutingModule } from './app-routing.module';
 import { AppComponent } from './app.component';
-import { ItemsComponent } from './item/items.component';
 import { ItemDetailComponent } from './item/item-detail.component';
+import { ItemsComponent } from './item/items.component';
 import { ModalComponent } from './modal/modal.component';
 
 /**
diff --git a/apps/nativescript-demo-ng/src/app/boot-guard.service.ts b/apps/nativescript-demo-ng/src/app/boot-guard.service.ts
diff --git a/apps/nativescript-demo-ng/src/app/modal/modal.component.ts b/apps/nativescript-demo-ng/src/app/modal/modal.component.ts
@@ -1,4 +1,4 @@
-import { Component, Inject, OnDestroy, OnInit, Optional, ViewContainerRef, inject } from '@angular/core';
+import { Component, OnDestroy, OnInit, Optional, ViewContainerRef, inject } from '@angular/core';
 import { ModalDialogService, NativeDialogRef, NativeDialogService } from '@nativescript/angular';
 import { ItemService } from '../item/item.service';
 
@@ -12,7 +12,12 @@ export class ModalComponent implements OnInit, OnDestroy {
   logo: string;
   color: string;
 
-  constructor(@Optional() private ref: NativeDialogRef<ModalComponent>, private nativeDialog: NativeDialogService, private modalDialog: ModalDialogService, private vcRef: ViewContainerRef) {
+  constructor(
+    @Optional() private ref: NativeDialogRef<ModalComponent>,
+    private nativeDialog: NativeDialogService,
+    private modalDialog: ModalDialogService,
+    private vcRef: ViewContainerRef,
+  ) {
     this.logo = this.itemService.flavors[this.itemService.currentFlavor].logo;
     this.color = this.itemService.flavors[this.itemService.currentFlavor].color;
   }
@@ -21,8 +26,8 @@ export class ModalComponent implements OnInit, OnDestroy {
     this.itemService.currentFlavor++;
     this.nativeDialog.open(ModalComponent, {
       nativeOptions: {
-        fullscreen: !!global.isAndroid
-      }
+        fullscreen: !!global.isAndroid,
+      },
     });
     // this.modalDialog.showModal(ModalComponent, {
     //   viewContainerRef: this.vcRef
diff --git a/apps/nativescript-demo-ng/src/tests/detached-loader-tests.spec.ts b/apps/nativescript-demo-ng/src/tests/detached-loader-tests.spec.ts
@@ -17,7 +17,7 @@ class LoaderComponentBase {
 }
 
 @Component({
-  selector: 'loader-component-on-push',
+  selector: 'loader-component',
   template: `
     <StackLayout>
       <DetachedContainer #loader></DetachedContainer>
diff --git a/apps/nativescript-demo-ng/src/tests/property-sets.spec.ts b/apps/nativescript-demo-ng/src/tests/property-sets.spec.ts
@@ -7,7 +7,7 @@ class TestView extends View implements NgView {
   public meta: ViewClassMeta = { skipAddToDom: false };
   public nodeType = 1;
   public nodeName = 'TestView';
-  // @ts-ignore
+  // @ts-expect-error setter
   public parentNode: NgView = null;
   public previousSibling: NgView;
   public nextSibling: NgView;

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,9 @@`
`24`	`24`	`"prefix": "",`
`25`	`25`	`"style": "kebab-case"`
`26`	`26`	`}`
`27`		`- ]`
	`27`	`+ ],`
	`28`	`+ "@typescript-eslint/no-explicit-any": "warn",`
	`29`	`+ "@typescript-eslint/no-unused-vars": "warn"`
`28`	`30`	`}`
`29`	`31`	`},`
`30`	`32`	`{`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ class LoaderComponentBase {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`@Component({`
`20`		`- selector: 'loader-component-on-push',`
	`20`	`+ selector: 'loader-component',`
`21`	`21`	template: `
`22`	`22`	`<StackLayout>`
`23`	`23`	`<DetachedContainer #loader></DetachedContainer>`