-
-
Notifications
You must be signed in to change notification settings - Fork 241
Proposal: Add @App Decorator #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Personally I’m struggling to see the benefit of abstracting that configuration, especially considering the bootstrapping is so trivial. To me it’s important to keep the app structure and code conventions as close to Angular’s own setup on their tutorials and such—that’s why the current starting template is setup the way that it is. I would be hesitant to add anything that moves us away from Angular’s own conventions, and it seems like an @app decorator would. |
The starting template is very similar to the project in Angular2 (Web) angular2 starter project so i'll give a thumbs up there. i'll agree that I wouldn't go as far as saying its moving away from convention but rather throwing a blanket over it while hiding it behind a different curtain just as the So the difference to the starting template would be dropping the main.js and pointing the package.json to start at app.component.ts Given the app.component.ts file it could look like:
Which in my opinion is a little nicer and expresses the workflow and purpose a bit better. Failing to argue my point in a effective way however ... could the |
@matt4446 I’ll let others give their opinions about the |
@tjvantoll #156 added. |
We were discussing this today, and it seems that the I'll close the issue for the time being, and, of course, we could reconsider it in the future. |
Could we have a similar decorator to Ionic added to nativescript-angular that hides away the bootstrapping and defines the app configuration?
Ionic 2 - app decorator
My implementation is here, although messy and out of date:
decorator: app.ts
Which reduces the ts/js files in the ./app to just one like:
app/app.ts
I'm struggling to give any benefits :) ...
I guess it might be personal preference. What do others think?
The text was updated successfully, but these errors were encountered: