Skip to content

topmost deprecate (first build after upgrade to v.6.2) #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Cheas opened this issue Nov 6, 2019 · 4 comments
Closed

topmost deprecate (first build after upgrade to v.6.2) #2054

Cheas opened this issue Nov 6, 2019 · 4 comments

Comments

@Cheas
Copy link

Cheas commented Nov 6, 2019

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.2
  • Cross-platform modules: 6.2
  • Android Runtime: 6.2
  • Plugin(s):
    "@nstudio/nativescript-cardview": "^1.0.0",
    "@nstudio/nativescript-snackbar": "^1.0.0",
    "base-64": "^0.1.0",
    "email-validator": "^2.0.4",
    "guid-typescript": "^1.0.9",
    "nativescript-angular": "~8.2.0",
    "nativescript-iqkeyboardmanager": "^1.5.1",
    "nativescript-plugin-firebase": "^10.0.1",
    "nativescript-theme-core": "~1.0.6",
    "nativescript-ui-listview": "^7.0.5",
    "reflect-metadata": "~0.1.12",
    "rxjs": "^6.4.0",
    "sha1": "^1.1.1",
    "tns-core-modules": "^6.2.0",
    "underscore": "^1.9.1",
    "utf8": "^3.0.0",
  • NativeScript-Angular: ~8.2
  • Angular: ~8.2

Describe the bug

  1. After building the project on the 6.2 android emulator, a message appeared on console:

topmost() is deprecated. Use Frame.topmost() instead.

I do not use it (topmost) directly. There is a list (RadListView) on the page and scrolling does not occur. When you re-enter the page, everything is OK.

  1. When building the release, a message appeared
ERROR in NativeScriptSnapshot. Snapshot generation failed!
Docker installation cannot be found. Install Docker and add it to your PATH in order to build snapshots.
Executing webpack failed with exit code 2.

I deleted the parameter --env.snapshot and managed to collect the release.

In previous versions, this was not.

@elena-p
Copy link
Contributor

elena-p commented Nov 7, 2019

Hi @Cheas,

Regarding the first issue topmost() is deprecated. Use Frame.topmost() instead. there is a new release of nativescript-ui-listview@8.0.0 in which this usage is changed and the warning does not appear. Could you test with that version and log a new issue in https://github.com/NativeScript/nativescript-ui-feedback/issues if there is anything not working with the scroll.

Regarding your second issue, I have transferred it to NativeScript/nativescript-cli#5116 where it could be answered in detail.

@elena-p elena-p changed the title topmost deprecate && release need Docker (first build after upgrade to v.6.2) topmost deprecate (first build after upgrade to v.6.2) Nov 7, 2019
@elena-p elena-p closed this as completed Nov 7, 2019
@Cheas
Copy link
Author

Cheas commented Nov 7, 2019

Hi. elena-p.
I changed the package "nativescript-ui-listview": "^7.0.5" to "nativescript-ui-listview": "8.0.0", same result.
I will research to get more information. The message appears randomly and until I see a pattern.

@Cheas
Copy link
Author

Cheas commented Nov 11, 2019

The problem disappeared after replacing the version Angular 8.2.0 to 8.2.13.
Thanks for your attention.

@alereisan
Copy link

@Cheas I had to upgrade Angular and nativescript-angular packages both, then the topmost warning is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants