Skip to content

Commit b8f15a0

Browse files
committed
feat(doctor): add android-33 to supported sdks
1 parent 1da28bc commit b8f15a0

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

packages/doctor/src/android-tools-info.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
2929
"android-30",
3030
"android-31",
3131
"android-32",
32+
"android-33",
3233
];
3334

3435
const isRuntimeVersionLessThan = (targetVersion: string) => {

packages/doctor/test/android-tools-info.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ describe("androidToolsInfo", () => {
5555
"30.0.0",
5656
"31.0.0",
5757
"32.0.0",
58+
"33.0.0",
5859
];
5960
} else {
6061
return [
@@ -65,6 +66,7 @@ describe("androidToolsInfo", () => {
6566
"android-30",
6667
"android-31",
6768
"android-32",
69+
"android-33",
6870
];
6971
}
7072
},
@@ -100,7 +102,7 @@ describe("androidToolsInfo", () => {
100102
const androidToolsInfo = getAndroidToolsInfo("8.2.0");
101103
const toolsInfo = androidToolsInfo.getToolsInfo({ projectDir: "test" });
102104

103-
assert.equal(toolsInfo.compileSdkVersion, 32);
105+
assert.equal(toolsInfo.compileSdkVersion, 33);
104106
});
105107
});
106108

@@ -132,10 +134,11 @@ describe("androidToolsInfo", () => {
132134
assertSupportedRange("8.1.0", min, max);
133135
});
134136

135-
it("runtime 8.2.0 should support android-17 - android-32", () => {
137+
it("runtime 8.2.0 should support android-17 - android-33", () => {
136138
const min = 17;
137-
const max = 32;
139+
const max = 33;
138140
assertSupportedRange("8.2.0", min, max);
141+
assertSupportedRange("8.3.0", min, max);
139142
});
140143
});
141144

0 commit comments

Comments
 (0)