-
-
Notifications
You must be signed in to change notification settings - Fork 197
HMR does not work correctly in code sharing project #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @erkanarslan, Thank you for logging this. Hot Module Replacement (HMR) is currently in Beta and for NativeScript-Angular projects, every change in This means that the native app is kept alive while the angular app inside starts again. For example, Improving the HMR feature is in our roadmap as the goal is to apply changes without bootstrap. |
Hi @erkanarslan,
It is expected to bootstrap the angular app on change but the change should be applied and visible. It'd be great appreciated if you can send us the whole project and exact steps so we can reproduce the problem on our side. You can share your files with me in the NativeScript Community Slack https://nativescriptcommunity.slack.com/ - my username is |
I'm closing this issue due to inactivity. Please, reopen if still experience the problem along with a sample project. |
hi updating the code from html will update the app but if i change something in typescript its not updating the application Please help
|
Environment
Provide version numbers for the following components (information can be retrieved by running
tns info
in your project folder or by inspecting thepackage.json
of the project):Describe the bug
I have an Angular code sharing project. HMR does not work properly. When I start the app, it loads the login page. I can change input attributes like placeholder and it is updated without page refresh. However, when I try to make a change in another page, page is reloaded and sometimes changes applied and sometimes not.
I tried changing a text in ActionBar. Page reloaded, text didn't change.
I tried removing an element from page. Page reloaded, element isn't removed.
I tried changing a function in .ts file. Page reloaded, function changed.
I think also HMR cannot handle angular directives like *ngIf and *ngFor.
To Reproduce
Create a code sharing project with navigation. Navigate to a page. Try changing content while hmr is enabled.
Expected behavior
Should update without reload.
Sample project
If you need, I can send you my whole project via email.
The text was updated successfully, but these errors were encountered: