fix: stop creating hooks on npm i in plugin folders.

Dimitar Tachev · Dimitar Tachev · commit f8ba6b94ec06 · 2018-02-09T18:30:54.000+02:00
diff --git a/index.js b/index.js
@@ -24,29 +24,42 @@ function generateHookName(pkg, hook) {
 }
 
 function findProjectDir(pkgdir) {
-	if (process.env.INIT_CWD) {
+	if (process.env.INIT_CWD && _isNativeScriptAppRoot(process.env.INIT_CWD)) {
 		return process.env.INIT_CWD;
 	}
 
 	var candidateDir = pkgdir;
+	var oldCandidateDir = null;
 
 	while (true) {
-		var oldCandidateDir = candidateDir;
 		candidateDir = path.dirname(candidateDir);
+		if (oldCandidateDir === candidateDir) {
+			return;
+		}
+
 		if (path.basename(candidateDir) === 'node_modules') {
 			continue;
 		}
-		var packageJsonFile = path.join(candidateDir, 'package.json');
-		if (fs.existsSync(packageJsonFile)) {
+		
+		if (_isNativeScriptAppRoot(candidateDir)) {
 			return candidateDir;
 		}
 
-		if (oldCandidateDir === candidateDir) {
-			return;
-		}
+		oldCandidateDir = candidateDir;
 	}
 }
 
+function _isNativeScriptAppRoot(dir) {
+	var isNativeScriptAppRoot = false;
+	var packageJsonFile = path.join(dir, 'package.json');
+	if (fs.existsSync(packageJsonFile)) {
+		var packageJsonContent = require(packageJsonFile);
+		isNativeScriptAppRoot = !!packageJsonContent.nativescript && !!packageJsonContent.nativescript.id;
+	}
+
+	return isNativeScriptAppRoot;
+}
+
 function forEachHook(pkgdir, callback) {
 	var pkg = require(path.join(pkgdir, 'package.json'));
 	var ns = pkg.nativescript;
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nativescript-hook",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "Helper module for installing hooks into NativeScript projects",
   "main": "index.js",
   "scripts": {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "nativescript-hook",`
`3`		`- "version": "0.2.2",`
	`3`	`+ "version": "0.2.3",`
`4`	`4`	`"description": "Helper module for installing hooks into NativeScript projects",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"scripts": {`