fix(imagepicker): build options

NathanWalker · NathanWalker · commit 029d4c58a88f · 2024-06-25T10:01:52.000-07:00
diff --git a/packages/imagepicker/common.ts b/packages/imagepicker/common.ts
@@ -88,6 +88,16 @@ export interface Options {
 	 */
 	numberOfColumnsInLandscape?: number;
 
+	/**
+	 * Set to false on iOS to disable querying thumbnail/filesize for selected assets
+	 */
+	augmentedAssetsInfo?: boolean;
+
+	/**
+	 * Set to true on iOS to wait for controller to be dismissed before resolving
+	 */
+	resolveWhenDismissed?: boolean;
+
 	/**
 	 * Set the media type (image/video/any) to pick
 	 */
diff --git a/packages/imagepicker/index.d.ts b/packages/imagepicker/index.d.ts
@@ -106,12 +106,12 @@ interface Options {
 	/**
 	 * Set to false on iOS to disable querying thumbnail/filesize for selected assets
 	 */
-	augmentedAssetsInfo: boolean;
+	augmentedAssetsInfo?: boolean;
 
 	/**
 	 * Set to true on iOS to wait for controller to be dismissed before resolving
 	 */
-	resolveWhenDismissed: boolean;
+	resolveWhenDismissed?: boolean;
 
 	/**
 	 * Set the media type (image/video/any) to pick
diff --git a/packages/imagepicker/index.ios.ts b/packages/imagepicker/index.ios.ts
@@ -92,7 +92,7 @@ class ImagePickerControllerDelegate extends NSObject implements QBImagePickerCon
 		});
 	}
 
-	async qb_imagePickerControllerDidFinishPickingAssets?(imagePickerController: QBImagePickerController, iosAssets: NSArray<any>): void {
+	async qb_imagePickerControllerDidFinishPickingAssets?(imagePickerController: QBImagePickerController, iosAssets: NSArray<any>) {
 		for (let i = 0; i < iosAssets.count; i++) {
 			const asset = new ImageAsset(iosAssets.objectAtIndex(i));
 			const phAssetImage: PHAsset = (<any>asset)._ios;
@@ -119,7 +119,7 @@ class ImagePickerControllerDelegate extends NSObject implements QBImagePickerCon
 			} else {
 				const imageOptions = new PHContentEditingInputRequestOptions();
 				imageOptions.networkAccessAllowed = true;
-				await new Promise(resolve => {
+				await new Promise<void>((resolve) => {
 					phAssetImage.requestContentEditingInputWithOptionsCompletionHandler(imageOptions, (thing) => {
 						fileMap[existingFileName].path = thing.fullSizeImageURL.toString().replace('file://', '');
 						resolve();
@@ -128,7 +128,7 @@ class ImagePickerControllerDelegate extends NSObject implements QBImagePickerCon
 			}
 		}
 		let wasDismissed = false;
-		const closePromise = new Promise(resolve => {
+		const closePromise = new Promise<void>((resolve) => {
 			imagePickerController.dismissViewControllerAnimatedCompletion(true, () => {
 				wasDismissed = true;
 				resolve();
@@ -190,7 +190,7 @@ class ImagePickerControllerDelegate extends NSObject implements QBImagePickerCon
 				count++;
 			}
 
-			Promise.all(promises).then(() => {
+			Promise.all(promises).then(async () => {
 				const results: ImagePickerSelection[] = [];
 				for (const key in fileMap) {
 					results.push(fileMap[key]);
diff --git a/packages/imagepicker/package.json b/packages/imagepicker/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "@nativescript/imagepicker",
-	"version": "3.1.1",
+	"version": "3.2.0",
 	"description": "A plugin for the NativeScript framework implementing multiple image picker",
 	"main": "index",
 	"typings": "index.d.ts",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@nativescript/imagepicker",`
`3`		`- "version": "3.1.1",`
	`3`	`+ "version": "3.2.0",`
`4`	`4`	`"description": "A plugin for the NativeScript framework implementing multiple image picker",`
`5`	`5`	`"main": "index",`
`6`	`6`	`"typings": "index.d.ts",`