Skip to content

Commit 067407d

Browse files
NathanWalkerNathanWalker
authored
chore: moved swift-ui, jetpack-compose, ionic-portals to ui-kit repo (#514)
To simplify source management in this repo, moved UI specific plugins with specific testing infrastructure to different workspace for ease of maintenance.
1 parent 782b68f commit 067407d

File tree

1,541 files changed

+5
-143748
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,541 files changed

+5
-143748
lines changed

‎.gitignore

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,4 @@ packages/shared-notification-delegate/common.js.map
5454
# iOS:
5555
packages/**/native-src/ios/**/xcuserdata/
5656
packages/**/native-src/ios/**/project.xcworkspace/
57-
packages/**/native-src/ios/**/build
58-
59-
# Ionic Portals and testing
60-
!packages/ionic-portals/platforms/android/IonicPortals-release.aar
61-
tools/assets/App_Resources/iOS/ionicWebPortalSample
62-
tools/assets/App_Resources/Android/src/main/assets/ionicWebPortalSample
63-
tools/assets/App_Resources/iOS/ionicWebStart
64-
tools/assets/App_Resources/Android/src/main/assets/ionicWebStart
65-
tools/assets/App_Resources/iOS/ionicWebModal
66-
tools/assets/App_Resources/Android/src/main/assets/ionicWebModal
57+
packages/**/native-src/ios/**/build

‎README.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
# @nativescript/\* plugins
2-
3-
```
4-
npm run setup
5-
npm start
6-
```
7-
81
- [@nativescript/animated-circle](packages/animated-circle/README.md)
92
- [@nativescript/appavailability](packages/appavailability/README.md)
103
- [@nativescript/apple-sign-in](packages/apple-sign-in/README.md)
@@ -27,18 +20,15 @@ npm start
2720
- [@nativescript/google-signin](packages/google-signin/README.md)
2821
- [@nativescript/haptics](packages/haptics/README.md)
2922
- [@nativescript/imagepicker](packages/imagepicker/README.md)
30-
- [@nativescript/ionic-portals](packages/ionic-portals/README.md)
3123
- [@nativescript/ios-security](packages/ios-security/README.md)
3224
- [@nativescript/iqkeyboardmanager](packages/iqkeyboardmanager/README.md)
33-
- [@nativescript/jetpack-compose](packages/jetpack-compose/README.md)
3425
- [@nativescript/local-notifications](packages/local-notifications/README.md)
3526
- [@nativescript/localize](packages/localize/README.md)
3627
- [@nativescript/pdf](packages/pdf/README.md)
3728
- [@nativescript/picker](packages/picker/README.md)
3829
- [@nativescript/secure-storage](packages/secure-storage/README.md)
3930
- [@nativescript/shared-notification-delegate](packages/shared-notification-delegate/README.md)
4031
- [@nativescript/social-share](packages/social-share/README.md)
41-
- [@nativescript/swift-ui](packages/swift-ui/README.md)
4232
- [@nativescript/theme-switcher](packages/theme-switcher/README.md)
4333
- [@nativescript/twitter](packages/twitter/README.md)
4434
- [@nativescript/zip](packages/zip/README.md)
@@ -52,13 +42,6 @@ This workspace manages the suite of plugins listed above.
5242
- Node 18+ is recommended
5343
- [yarn v1](https://classic.yarnpkg.com/lang/en/docs/install/#mac-stable) is required
5444

55-
### Note about "focus modes"
56-
57-
`npm start` > `focus.{any-plugin}` ENTER will focus the workspace to a single plugin for working on it in isolation.
58-
59-
Generally we try to keep "UI" plugins away from "SDK" related plugins since UI plugins often bring in aspects which may need more resource setup. For example, since the swift-ui plugin is currently managed here, we have testing code for it here: https://github.com/NativeScript/plugins/blob/main/tools/assets/App_Resources/iOS/src/BasicViewProvider.swift ... however when focusing on any other plugins, you would need to rename those .swift > .off so they aren't included in the demo to work with other plugins. Since the supporting .swift files include SwiftUIProvider which comes from only the swift-ui plugin.
60-
To help contributors in the future, we will likely split some of these plugins out across other workspaces to pair it down. For now that tip can be applied where needed to work on any plugin.
61-
6245
In general, when in doubt with what to do, just `npm start`.
6346

6447
```bash

‎apps/demo-angular/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"main": "./src/main.ts",
33
"dependencies": {
44
"@nativescript/core": "file:../../node_modules/@nativescript/core",
5-
"@nativescript/jetpack-compose": "file:../../dist/packages/jetpack-compose",
65
"@nativescript/animated-circle": "file:../../dist/packages/animated-circle",
76
"@nativescript/appavailability": "file:../../dist/packages/appavailability",
87
"@nativescript/apple-sign-in": "file:../../dist/packages/apple-sign-in",
@@ -25,7 +24,6 @@
2524
"@nativescript/google-signin": "file:../../dist/packages/google-signin",
2625
"@nativescript/haptics": "file:../../dist/packages/haptics",
2726
"@nativescript/imagepicker": "file:../../dist/packages/imagepicker",
28-
"@nativescript/ionic-portals": "file:../../dist/packages/ionic-portals",
2927
"@nativescript/ios-security": "file:../../dist/packages/ios-security",
3028
"@nativescript/iqkeyboardmanager": "file:../../dist/packages/iqkeyboardmanager",
3129
"@nativescript/local-notifications": "file:../../dist/packages/local-notifications",
@@ -34,7 +32,6 @@
3432
"@nativescript/picker": "file:../../dist/packages/picker",
3533
"@nativescript/shared-notification-delegate": "file:../../dist/packages/shared-notification-delegate",
3634
"@nativescript/social-share": "file:../../dist/packages/social-share",
37-
"@nativescript/swift-ui": "file:../../dist/packages/swift-ui",
3835
"@nativescript/theme-switcher": "file:../../dist/packages/theme-switcher",
3936
"@nativescript/twitter": "file:../../dist/packages/twitter",
4037
"@nativescript/zip": "file:../../dist/packages/zip",

‎apps/demo-angular/src/app-routing.module.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,15 @@ const routes: Routes = [
2929
{ path: 'google-signin', loadChildren: () => import('./plugin-demos/google-signin.module').then((m) => m.GoogleSigninModule) },
3030
{ path: 'haptics', loadChildren: () => import('./plugin-demos/haptics.module').then((m) => m.HapticsModule) },
3131
{ path: 'imagepicker', loadChildren: () => import('./plugin-demos/imagepicker.module').then((m) => m.ImagepickerModule) },
32-
{ path: 'ionic-portals', loadChildren: () => import('./plugin-demos/ionic-portals.module').then((m) => m.IonicPortalsModule) },
3332
{ path: 'ios-security', loadChildren: () => import('./plugin-demos/ios-security.module').then((m) => m.IosSecurityModule) },
3433
{ path: 'iqkeyboardmanager', loadChildren: () => import('./plugin-demos/iqkeyboardmanager.module').then((m) => m.IqkeyboardmanagerModule) },
35-
{ path: 'jetpack-compose', loadChildren: () => import('./plugin-demos/jetpack-compose.module').then((m) => m.JetpackComposeModule) },
3634
{ path: 'local-notifications', loadChildren: () => import('./plugin-demos/local-notifications.module').then((m) => m.LocalNotificationsModule) },
3735
{ path: 'localize', loadChildren: () => import('./plugin-demos/localize.module').then((m) => m.LocalizeModule) },
3836
{ path: 'pdf', loadChildren: () => import('./plugin-demos/pdf.module').then((m) => m.PdfModule) },
3937
{ path: 'picker', loadChildren: () => import('./plugin-demos/picker.module').then((m) => m.PickerModule) },
4038
{ path: 'secure-storage', loadChildren: () => import('./plugin-demos/secure-storage.module').then((m) => m.SecureStorageModule) },
4139
{ path: 'shared-notification-delegate', loadChildren: () => import('./plugin-demos/shared-notification-delegate.module').then((m) => m.SharedNotificationDelegateModule) },
4240
{ path: 'social-share', loadChildren: () => import('./plugin-demos/social-share.module').then((m) => m.SocialShareModule) },
43-
{ path: 'swift-ui', loadChildren: () => import('./plugin-demos/swift-ui.module').then((m) => m.SwiftUiModule) },
4441
{ path: 'theme-switcher', loadChildren: () => import('./plugin-demos/theme-switcher.module').then((m) => m.ThemeSwitcherModule) },
4542
{ path: 'twitter', loadChildren: () => import('./plugin-demos/twitter.module').then((m) => m.TwitterModule) },
4643
{ path: 'zip', loadChildren: () => import('./plugin-demos/zip.module').then((m) => m.ZipModule) },

‎apps/demo-angular/src/home.component.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,18 +72,12 @@ export class HomeComponent {
7272
{
7373
name: 'imagepicker',
7474
},
75-
{
76-
name: 'ionic-portals',
77-
},
7875
{
7976
name: 'ios-security',
8077
},
8178
{
8279
name: 'iqkeyboardmanager',
8380
},
84-
{
85-
name: 'jetpack-compose',
86-
},
8781
{
8882
name: 'local-notifications',
8983
},
@@ -105,9 +99,6 @@ export class HomeComponent {
10599
{
106100
name: 'social-share',
107101
},
108-
{
109-
name: 'swift-ui',
110-
},
111102
{
112103
name: 'theme-switcher',
113104
},

‎apps/demo-angular/src/plugin-demos/ionic-portals.component.html

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎apps/demo-angular/src/plugin-demos/ionic-portals.component.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

‎apps/demo-angular/src/plugin-demos/ionic-portals.module.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎apps/demo-angular/src/plugin-demos/jetpack-compose.component.html

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎apps/demo-angular/src/plugin-demos/jetpack-compose.component.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎apps/demo-angular/src/plugin-demos/jetpack-compose.module.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎apps/demo-angular/src/plugin-demos/swift-ui.component.html

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎apps/demo-angular/src/plugin-demos/swift-ui.component.ts

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎apps/demo-angular/src/plugin-demos/swift-ui.module.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎apps/demo-angular/tsconfig.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
"@nativescript/facebook": ["packages/facebook/index.d.ts"],
3636
"@nativescript/google-signin": ["packages/google-signin/index.d.ts"],
3737
"@nativescript/twitter": ["packages/twitter/index.d.ts"],
38-
"@nativescript/ionic-portals": ["packages/ionic-portals/index.d.ts"],
3938
"@nativescript/theme-switcher": ["packages/theme-switcher/index.ts"],
4039
"@nativescript/biometrics": ["packages/biometrics/index.d.ts"],
4140
"@nativescript/apple-sign-in": ["packages/apple-sign-in/index.d.ts"],

‎apps/demo/nativescript.config.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,6 @@ export default {
99
},
1010
appPath: 'src',
1111
cli: {
12-
packageManager: 'npm'
12+
packageManager: 'npm',
1313
},
14-
hooks: [
15-
{
16-
type: 'before-prepare',
17-
script: '../../tools/scripts/before-prepare.js',
18-
}
19-
],
2014
} as NativeScriptConfig;

‎apps/demo/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"repository": "<fill-your-repository-here>",
66
"dependencies": {
77
"@nativescript/core": "file:../../node_modules/@nativescript/core",
8-
"@nativescript/jetpack-compose": "file:../../packages/jetpack-compose",
98
"@nativescript/animated-circle": "file:../../packages/animated-circle",
109
"@nativescript/appavailability": "file:../../packages/appavailability",
1110
"@nativescript/apple-sign-in": "file:../../packages/apple-sign-in",
@@ -28,7 +27,6 @@
2827
"@nativescript/google-signin": "file:../../packages/google-signin",
2928
"@nativescript/haptics": "file:../../packages/haptics",
3029
"@nativescript/imagepicker": "file:../../packages/imagepicker",
31-
"@nativescript/ionic-portals": "file:../../packages/ionic-portals",
3230
"@nativescript/ios-security": "file:../../packages/ios-security",
3331
"@nativescript/iqkeyboardmanager": "file:../../packages/iqkeyboardmanager",
3432
"@nativescript/local-notifications": "file:../../packages/local-notifications",
@@ -37,7 +35,6 @@
3735
"@nativescript/picker": "file:../../packages/picker",
3836
"@nativescript/shared-notification-delegate": "file:../../packages/shared-notification-delegate",
3937
"@nativescript/social-share": "file:../../packages/social-share",
40-
"@nativescript/swift-ui": "file:../../packages/swift-ui",
4138
"@nativescript/theme-switcher": "file:../../packages/theme-switcher",
4239
"@nativescript/twitter": "file:../../packages/twitter",
4340
"@nativescript/zip": "file:../../packages/zip",

‎apps/demo/src/app.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,4 @@ import { Application } from '@nativescript/core';
1111
// import { LoginManager } from '@nativescript/facebook';
1212
// LoginManager.init();
1313

14-
// uncomment to test Ionic Portals
15-
// import { IonicPortalManager } from '@nativescript/ionic-portals';
16-
// IonicPortalManager.configureLiveUpdates('ionicWebPortalSample', {
17-
// appId: 'e29e2c2e',
18-
// channel: 'production',
19-
// syncOnAdd: true
20-
// })
21-
22-
// Application.on(Application.launchEvent, () => {
23-
// // Register IonicPortals
24-
// IonicPortalManager.register('<portal-api-key>');
25-
// });
26-
2714
Application.run({ moduleName: 'app-root' });

‎apps/demo/src/main-page.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@
2727
<Button text="google-signin" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
2828
<Button text="haptics" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
2929
<Button text="imagepicker" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
30-
<Button text="ionic-portals" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
30+
3131
<Button text="ios-security" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
3232
<Button text="iqkeyboardmanager" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
33-
<Button text="jetpack-compose" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
33+
3434
<Button text="local-notifications" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
3535
<Button text="localize" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
3636
<Button text="pdf" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
3737
<Button text="picker" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
3838
<Button text="shared-notification-delegate" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
3939
<Button text="social-share" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
40-
<Button text="swift-ui" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
40+
4141
<Button text="theme-switcher" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
4242
<Button text="twitter" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>
4343
<Button text="zip" tap="{{ viewDemo }}" class="btn btn-primary view-demo"/>

0 commit comments

Comments
 (0)