feat(google-maps): marker visible accessors (#313)

lekhmanrus · web-flow · commit 14d6b48ff0e0 · 2022-08-12T14:59:11.000-07:00
diff --git a/packages/google-maps/index.android.ts b/packages/google-maps/index.android.ts
@@ -1070,6 +1070,14 @@ export class Marker extends OverLayBase implements IMarker {
 		this.native.setRotation(value);
 	}
 
+	get visible(): boolean {
+		return this.native.isVisible();
+	}
+
+	set visible(value) {
+		this.native.setVisible(value);
+	}
+
 	get flat(): boolean {
 		return this.native.isFlat();
 	}
diff --git a/packages/google-maps/index.d.ts b/packages/google-maps/index.d.ts
@@ -296,6 +296,7 @@ export interface IMarker {
 	icon: any /* Image, ImageSource, UIImage & Bitmap */;
 	color: Color | string;
 	rotation: number;
+	visible: boolean;
 	flat: boolean;
 	zIndex: number;
 	userData: { [key: string]: any };
@@ -315,6 +316,7 @@ export class Marker implements IMarker, Partial<NativeObject> {
 	icon: any; /* Image, ImageSource, UIImage & Bitmap */
 	color: Color | string;
 	rotation: number;
+	visible: boolean;
 	flat: boolean;
 	zIndex: number;
 	userData: { [key: string]: any };
diff --git a/packages/google-maps/index.ios.ts b/packages/google-maps/index.ios.ts
@@ -984,6 +984,7 @@ abstract class OverLayBase {
 export class Marker extends OverLayBase implements IMarker {
 	#native: GMSMarker;
 	#color = new Color('red');
+	#visible = true;
 	static fromNative(nativeMarker: GMSMarker) {
 		if (nativeMarker instanceof GMSMarker) {
 			const marker = new Marker();
@@ -1079,6 +1080,15 @@ export class Marker extends OverLayBase implements IMarker {
 		this.native.rotation = value;
 	}
 
+	get visible(): boolean {
+		return this.#visible;
+	}
+
+	set visible(value: boolean) {
+		this.#visible = value;
+		this.native.opacity = this.visible ? 1 : 0;
+	}
+
 	get flat(): boolean {
 		return this.native.flat;
 	}
diff --git a/packages/google-maps/utils/index.android.ts b/packages/google-maps/utils/index.android.ts
@@ -80,6 +80,10 @@ export function intoNativeMarkerOptions(options: MarkerOptions) {
 		opts.rotation(options.rotation);
 	}
 
+	if (typeof options?.visible === 'boolean') {
+		opts.visible(options.visible);
+	}
+
 	if (typeof options?.flat === 'boolean') {
 		opts.flat(options.flat);
 	}
diff --git a/packages/google-maps/utils/index.ios.ts b/packages/google-maps/utils/index.ios.ts
@@ -64,6 +64,10 @@ export function intoNativeMarkerOptions(options: MarkerOptions) {
 		opts.rotation = options.rotation;
 	}
 
+	if (typeof options?.visible === 'boolean') {
+		opts.opacity = options.visible ? 1 : 0;
+	}
+
 	if (typeof options?.flat === 'boolean') {
 		opts.flat = options.flat;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1070,6 +1070,14 @@ export class Marker extends OverLayBase implements IMarker {`
`1070`	`1070`	`this.native.setRotation(value);`
`1071`	`1071`	`}`
`1072`	`1072`
	`1073`	`+ get visible(): boolean {`
	`1074`	`+ return this.native.isVisible();`
	`1075`	`+ }`
	`1076`	`+`
	`1077`	`+ set visible(value) {`
	`1078`	`+ this.native.setVisible(value);`
	`1079`	`+ }`
	`1080`	`+`
`1073`	`1081`	`get flat(): boolean {`
`1074`	`1082`	`return this.native.isFlat();`
`1075`	`1083`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,10 @@ export function intoNativeMarkerOptions(options: MarkerOptions) {`
`80`	`80`	`opts.rotation(options.rotation);`
`81`	`81`	`}`
`82`	`82`
	`83`	`+ if (typeof options?.visible === 'boolean') {`
	`84`	`+ opts.visible(options.visible);`
	`85`	`+ }`
	`86`	`+`
`83`	`87`	`if (typeof options?.flat === 'boolean') {`
`84`	`88`	`opts.flat(options.flat);`
`85`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,10 @@ export function intoNativeMarkerOptions(options: MarkerOptions) {`
`64`	`64`	`opts.rotation = options.rotation;`
`65`	`65`	`}`
`66`	`66`
	`67`	`+ if (typeof options?.visible === 'boolean') {`
	`68`	`+ opts.opacity = options.visible ? 1 : 0;`
	`69`	`+ }`
	`70`	`+`
`67`	`71`	`if (typeof options?.flat === 'boolean') {`
`68`	`72`	`opts.flat = options.flat;`
`69`	`73`	`}`