feat: IonicPortals 0.5.1 updates

NathanWalker · NathanWalker · commit 357bee81dd8f · 2022-03-27T15:48:20.000-07:00
diff --git a/packages/ionic-portals/index.ios.ts b/packages/ionic-portals/index.ios.ts
@@ -26,7 +26,7 @@ export class IonicPortal extends IonicPortalCommon {
 			throw new Error(`IonicPortal requires an 'id' property.`);
 		}
 		const portal = PortalManager.getPortalError(this.id);
-		const portalWebView = PortalWebView.alloc().initWithFramePortal(CGRectMake(0, 0, this.parent.ios.bounds.size.width, this.parent.ios.bounds.size.height), portal);
+		const portalWebView = PortalWebView.alloc().initWithPortal(portal);
 		return portalWebView;
 	}
 
diff --git a/packages/ionic-portals/platforms/ios/Podfile b/packages/ionic-portals/platforms/ios/Podfile
@@ -1 +1,3 @@
+platform :ios, '14.0'
+
 pod 'IonicPortals', '~> 0.5.1'
diff --git a/packages/ionic-portals/typings/objc!IonicPortals.d.ts b/packages/ionic-portals/typings/objc!IonicPortals.d.ts
@@ -1,4 +1,3 @@
-
 declare var IonicPortalsVersionNumber: number;
 
 declare var IonicPortalsVersionNumberVar: number;
@@ -8,14 +7,12 @@ declare var IonicPortalsVersionString: interop.Reference<number>;
 declare var IonicPortalsVersionStringVar: interop.Reference<number>;
 
 declare class Portal extends NSObject {
-
 	static alloc(): Portal; // inherited from NSObject
 
 	static new(): Portal; // inherited from NSObject
 }
 
 declare class PortalBuilder extends NSObject {
-
 	static alloc(): PortalBuilder; // inherited from NSObject
 
 	static new(): PortalBuilder; // inherited from NSObject
@@ -32,7 +29,6 @@ declare class PortalBuilder extends NSObject {
 }
 
 declare class PortalManager extends NSObject {
-
 	static addPortal(portal: Portal): void;
 
 	static alloc(): PortalManager; // inherited from NSObject
@@ -51,7 +47,6 @@ declare class PortalManager extends NSObject {
 }
 
 declare class PortalWebView extends UIView {
-
 	static alloc(): PortalWebView; // inherited from NSObject
 
 	static appearance(): PortalWebView; // inherited from UIAppearance
@@ -68,20 +63,18 @@ declare class PortalWebView extends UIView {
 
 	static new(): PortalWebView; // inherited from NSObject
 
-	constructor(o: { frame: CGRect; portal: Portal; });
+	constructor(o: { portal: Portal });
 
-	initWithFramePortal(frame: CGRect, portal: Portal): this;
+	initWithPortal(portal: Portal): this;
 }
 
 declare class PortalsPlugin extends CAPPlugin {
-
 	static alloc(): PortalsPlugin; // inherited from NSObject
 
 	static new(): PortalsPlugin; // inherited from NSObject
 }
 
 declare class UnregisteredView extends UIView {
-
 	static alloc(): UnregisteredView; // inherited from NSObject
 
 	static appearance(): UnregisteredView; // inherited from UIAppearance
diff --git a/tools/assets/App_Resources/iOS/Podfile b/tools/assets/App_Resources/iOS/Podfile
@@ -1,9 +1,10 @@
-platform :ios, '14.0'
+# platform :ios, '14.0'
 
 post_install do |installer|
     installer.pods_project.targets.each do |target|
         target.build_configurations.each do |config|
-            config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
+            config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '12.0'
+            # config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
         end
     end
 end
diff --git a/tools/assets/App_Resources/iOS/build.xcconfig b/tools/assets/App_Resources/iOS/build.xcconfig
@@ -4,4 +4,4 @@
 // To build for device with Xcode 8 you need to specify your development team. More info: https://developer.apple.com/library/prerelease/content/releasenotes/DeveloperTools/RN-Xcode/Introduction.html
 // DEVELOPMENT_TEAM = YOUR_TEAM_ID;
 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
-IPHONEOS_DEPLOYMENT_TARGET = 14.0
+IPHONEOS_DEPLOYMENT_TARGET = 12.0

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ export class IonicPortal extends IonicPortalCommon {`
`26`	`26`	throw new Error(`IonicPortal requires an 'id' property.`);
`27`	`27`	`}`
`28`	`28`	`const portal = PortalManager.getPortalError(this.id);`
`29`		`- const portalWebView = PortalWebView.alloc().initWithFramePortal(CGRectMake(0, 0, this.parent.ios.bounds.size.width, this.parent.ios.bounds.size.height), portal);`
	`29`	`+ const portalWebView = PortalWebView.alloc().initWithPortal(portal);`
`30`	`30`	`return portalWebView;`
`31`	`31`	`}`
`32`	`32`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+platform :ios, '14.0'`
	`2`	`+`
`1`	`3`	`pod 'IonicPortals', '~> 0.5.1'`