fix(localize): handle ios null key fixes #46 (#74)

janoshrubos · web-flow · commit 6bf56f5c7eb2 · 2021-01-29T10:37:14.000-08:00
diff --git a/packages/localize/hooks/data.provider.ts b/packages/localize/hooks/data.provider.ts
@@ -65,7 +65,7 @@ export class DataProvider {
 
 		if (!this.defaultLanguage) {
 			this.defaultLanguage = this.languages.keys().next().value;
-			this.logger.warn(`No file found with the .default extension: default langage set to '${this.defaultLanguage}'`);
+			this.logger.warn(`No file found with the .default extension: default language set to '${this.defaultLanguage}'`);
 		}
 
 		const defaultLanguageI18nEntries = this.languages.get(this.defaultLanguage);
diff --git a/packages/localize/index.ios.ts b/packages/localize/index.ios.ts
@@ -16,7 +16,12 @@ const getBundle = (function () {
 })();
 
 export function localize(key: string, ...args: string[]): string {
-	const localizedString = getBundle().localizedStringForKeyValueTable(encodeKey(key), key, null);
+	let localizedString;
+	try {
+		localizedString = getBundle().localizedStringForKeyValueTable(encodeKey(key), key, null);
+	} catch (error) {
+		localizedString = key;
+	}
 	return vsprintf(convertAtSignToStringSign(localizedString), args);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ export class DataProvider {`
`65`	`65`
`66`	`66`	`if (!this.defaultLanguage) {`
`67`	`67`	`this.defaultLanguage = this.languages.keys().next().value;`
`68`		- this.logger.warn(`No file found with the .default extension: default langage set to '${this.defaultLanguage}'`);
	`68`	+ this.logger.warn(`No file found with the .default extension: default language set to '${this.defaultLanguage}'`);
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`const defaultLanguageI18nEntries = this.languages.get(this.defaultLanguage);`