fix(google-signin): don't throw for id not found

triniwiz · NathanWalker · commit 8088d49efc6e · 2023-05-17T16:27:52.000-07:00
diff --git a/packages/google-signin/platforms/android/java/org/nativescript/plugins/googlesignin/GoogleSignIn.kt b/packages/google-signin/platforms/android/java/org/nativescript/plugins/googlesignin/GoogleSignIn.kt
@@ -129,8 +129,6 @@ class GoogleSignIn {
 					if (clientIdIdentifier != 0) {
 						builder.requestIdToken(activity.getString(clientIdIdentifier))
 						builder.requestServerAuthCode(activity.getString(clientIdIdentifier))
-					} else {
-						throw Exception("Failed to find string resource with identifier 'default_web_client_id'")
 					}
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,6 @@ class GoogleSignIn {`
`129`	`129`	`if (clientIdIdentifier != 0) {`
`130`	`130`	`builder.requestIdToken(activity.getString(clientIdIdentifier))`
`131`	`131`	`builder.requestServerAuthCode(activity.getString(clientIdIdentifier))`
`132`		`- } else {`
`133`		`- throw Exception("Failed to find string resource with identifier 'default_web_client_id'")`
`134`	`132`	`}`
`135`	`133`	`}`
`136`	`134`