release(social-share): 2.0.3 - make social options explicit only

NathanWalker · NathanWalker · commit ea0d1f8f6675 · 2021-02-03T13:38:36.000-08:00
Note in plugin README closes #81
diff --git a/packages/social-share/README.md b/packages/social-share/README.md
@@ -8,7 +8,7 @@ ns plugin add @nativescript/social-share
 
 To use the social share module you must first `require()` it. After you `require()` the module you have access to its APIs.
 
-``` JavaScript
+```JavaScript
 // ------------ JavaScript ------------------
 var SocialShare = require("@nativescript/social-share");
 
@@ -22,7 +22,7 @@ import * as SocialShare from "@nativescript/social-share";
 
 The `shareImage()` method expects an [`ImageSource`](http://docs.nativescript.org/ApiReference/image-source/ImageSource.html) object. The code below loads an image from the app and invokes the share widget with it:
 
-``` JavaScript
+```JavaScript
 // ------------ JavaScript ------------------
 var SocialShare = require("@nativescript/social-share");
 var imageSourceModule = require("@nativescript/core");
@@ -40,44 +40,111 @@ SocialShare.shareImage(image);
 
 You can optionally provide a second argument to configure the subject on Android:
 
-``` JavaScript
+```JavaScript
 SocialShare.shareImage(image, "How would you like to share this image?");
 ```
 
 ### shareText(String text, [optional] String subject)
 
 The `shareText()` method expects a simple string:
 
-``` js
-SocialShare.shareText("I love NativeScript!");
+```js
+SocialShare.shareText('I love NativeScript!');
 ```
 
 Like `shareImage()`, you can optionally pass `shareText()` a second argument to configure the subject on Android:
 
-``` js
-SocialShare.shareText("I love NativeScript!", "How would you like to share this text?");
+```js
+SocialShare.shareText('I love NativeScript!', 'How would you like to share this text?');
 ```
 
 ### shareUrl(String url, String text, [optional] String subject)
 
 The `shareUrl()` method excepts a url and a string.
 
-``` js
-SocialShare.shareUrl("https://www.nativescript.org/", "Home of NativeScript");
+```js
+SocialShare.shareUrl('https://www.nativescript.org/', 'Home of NativeScript');
 ```
 
 You can optionally pass `shareUrl()` a second argument to configure the subject on Android:
 
-``` js
-SocialShare.shareUrl("https://www.nativescript.org/", "Home of NativeScript", "How would you like to share this url?");
+```js
+SocialShare.shareUrl('https://www.nativescript.org/', 'Home of NativeScript', 'How would you like to share this url?');
+```
+
+### shareViaTwitter(text?: string, url?: string): Promise<void>;
+
+Share text or url via Twitter.
+
+/\*\*
+
+- Share via Facebook
+- @param {string} text - Text to share with URL.
+- @param {string} url - URL to share.
+  \*/
+
+```js
+SocialShare.shareViaTwitter('Home of NativeScript', 'https://www.nativescript.org/');
+```
+
+### shareViaFacebook(text?: string, url?: string): Promise<void>;
+
+Share url via Facebook. Note that `text` will usually be suppressed due to Facebook security/abuse prevention, but the url will come through.
+
+```js
+SocialShare.shareViaFacebook('Home of NativeScript', 'https://www.nativescript.org/');
+```
+
+- **Android Only NOTE**:
+
+If you are already using the Facebook Share SDK in your project you likely do _not_ have to add the following.
+
+If you are not using the sdk explicitly in your project yet, add to your `app.gradle`:
+
+```
+dependencies {
+	implementation 'com.facebook.android:facebook-share:[5,6)'
+}
+```
+
+- Add a `meta-data` section and `provider` section ot your `AndroidManifest.xml` so it becomes similar to this:
+
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+  xmlns:tools="http://schemas.android.com/tools"
+  ...>
+   	<application
+   		android:name="com.tns.NativeScriptApplication"
+   		..>
+
+   		<meta-data android:name="com.facebook.sdk.ApplicationId" android:value="@string/facebook_app_id"/>
+
+      <provider android:authorities="com.facebook.app.FacebookContentProvider{your-facebook-appid}"
+          android:name="com.facebook.FacebookContentProvider"
+          android:exported="true"
+          tools:replace="android:authorities"/>
+
+   		<activity
+   			android:name="com.tns.NativeScriptActivity"
+   			..>
+```
+
+- Create a file `facebooklogin.xml` in `App_Resources/Android/src/main/res/values/`. Add this to the file (replace the id):
+
+```xml
+<?xml version='1.0' encoding='utf-8'?>
+<resources>
+    <string name="facebook_app_id">126035687816994</string>
+</resources>
 ```
 
 ## Tutorials
 
 Looking for some extra help getting social sharing working in your mobile application? Check out these resources:
 
-* [Social Media Sharing in a Vanilla NativeScript Application](https://www.thepolyglotdeveloper.com/2016/03/implement-social-media-sharing-nativescript-app/)
-* [Social Media Sharing in a NativeScript with Angular Application](https://www.thepolyglotdeveloper.com/2017/02/social-media-sharing-prompts-nativescript-angular-application/)
+- [Social Media Sharing in a Vanilla NativeScript Application](https://www.thepolyglotdeveloper.com/2016/03/implement-social-media-sharing-nativescript-app/)
+- [Social Media Sharing in a NativeScript with Angular Application](https://www.thepolyglotdeveloper.com/2017/02/social-media-sharing-prompts-nativescript-angular-application/)
 
 ## License
 
diff --git a/packages/social-share/index.android.ts b/packages/social-share/index.android.ts
@@ -111,6 +111,11 @@ export function shareViaFacebook(text?: string, url?: string): Promise<void> {
 			if (!activity) {
 				reject('No activity found.');
 			} else {
+				if (typeof (<any>com).facebook === 'undefined' || typeof (<any>com).facebook.CallbackManager === 'undefined' || typeof (<any>com).facebook.share === 'undefined') {
+					console.error('Please follow usage instructions to add facebook sdk.');
+					reject();
+					return;
+				}
 				let manager = (<any>com).facebook.CallbackManager.Factory.create();
 				Application.android.off('activityResult');
 				Application.android.on('activityResult', (args) => {
diff --git a/packages/social-share/package.json b/packages/social-share/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "@nativescript/social-share",
-	"version": "2.0.2",
+	"version": "2.0.3",
 	"description": "Social sharing widget handling for NativeScript",
 	"main": "index",
 	"typings": "index.d.ts",
diff --git a/packages/social-share/platforms/android/AndroidManifest.xml b/packages/social-share/platforms/android/AndroidManifest.xml
@@ -10,9 +10,5 @@
 				android:name="android.support.FILE_PROVIDER_PATHS"
 				android:resource="@xml/provider_paths"/>
 		</provider>
-
-		<provider android:authorities="com.facebook.app.FacebookContentProvider${applicationId}"
-          android:name="com.facebook.FacebookContentProvider"
-          android:exported="true"/>
 	</application>
 </manifest>
diff --git a/packages/social-share/platforms/android/include.gradle b/packages/social-share/platforms/android/include.gradle
diff --git a/tools/assets/App_Resources/Android/app.gradle b/tools/assets/App_Resources/Android/app.gradle
@@ -1,9 +1,10 @@
-// Add your native dependencies here:
+repositories {
+	mavenCentral()
+}
 
-// Uncomment to add recyclerview-v7 dependency
-//dependencies {
-//	compile 'com.android.support:recyclerview-v7:+'
-//}
+dependencies {
+	implementation 'com.facebook.android:facebook-share:[5,6)'
+}
 
 android {  
   compileSdkVersion 29

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@nativescript/social-share",`
`3`		`- "version": "2.0.2",`
	`3`	`+ "version": "2.0.3",`
`4`	`4`	`"description": "Social sharing widget handling for NativeScript",`
`5`	`5`	`"main": "index",`
`6`	`6`	`"typings": "index.d.ts",`