check return code on RAND_bytes();

sjlombardo · sjlombardo · commit 979f690669a5 · 2013-06-11T13:11:41.000-04:00
diff --git a/src/crypto_openssl.c b/src/crypto_openssl.c
@@ -66,10 +66,9 @@ static const char* sqlcipher_openssl_get_provider_name(void *ctx) {
   return "openssl";
 }
 
-/* generate a defined number of pseudorandom bytes */
+/* generate a defined number of random bytes */
 static int sqlcipher_openssl_random (void *ctx, void *buffer, int length) {
-  RAND_bytes((unsigned char *)buffer, length);
-  return SQLITE_OK;
+  return (RAND_bytes((unsigned char *)buffer, length) == 1) ? SQLITE_OK : SQLITE_ERROR;
 }
 
 static int sqlcipher_openssl_hmac(void *ctx, unsigned char *hmac_key, int key_sz, unsigned char *in, int in_sz, unsigned char *in2, int in2_sz, unsigned char *out) {

Original file line number	Diff line number	Diff line change
`@@ -66,10 +66,9 @@ static const char* sqlcipher_openssl_get_provider_name(void *ctx) {`
`66`	`66`	`return "openssl";`
`67`	`67`	`}`
`68`	`68`
`69`		`-/* generate a defined number of pseudorandom bytes */`
	`69`	`+/* generate a defined number of random bytes */`
`70`	`70`	`static int sqlcipher_openssl_random (void ctx, void buffer, int length) {`
`71`		`- RAND_bytes((unsigned char *)buffer, length);`
`72`		`- return SQLITE_OK;`
	`71`	`+ return (RAND_bytes((unsigned char *)buffer, length) == 1) ? SQLITE_OK : SQLITE_ERROR;`
`73`	`72`	`}`
`74`	`73`
`75`	`74`	`static int sqlcipher_openssl_hmac(void ctx, unsigned char hmac_key, int key_sz, unsigned char in, int in_sz, unsigned char in2, int in2_sz, unsigned char *out) {`