Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PSModule/GitHub
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.36.5
Choose a base ref
...
head repository: PSModule/GitHub
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.36.6
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Sep 5, 2025

  1. 🪲 [Fix]: Fix an issue with all App/JWT tokens being marked as expired (… 

    …#497)

## Description

This pull request updates the handling of JWT token issue and expiry
times, ensuring consistent use of local time and simplifying the
calculation of token expiry intervals. The changes improve time zone
handling and streamline the logic for determining token validity.

**Improvements to JWT Time Handling:**

* Changed the calculation of `IssuedAt` and `ExpiresAt` in
`New-GitHubUnsignedJWT.ps1` to use `LocalDateTime` instead of
`DateTime`, ensuring the times are always in local time.
* In `Update-GitHubAppJWT.ps1`, added logic to convert `ExpiresAt` from
UTC to local time if needed before updating the context, further
standardizing time zone usage.

**Simplification of Token Expiry Calculation:**

* Simplified the `TokenExpiresIn` and `RefreshTokenExpiresIn` script
properties in `GitHubContext.Types.ps1xml` by removing redundant checks
for negative intervals and directly returning the time difference.

## Type of change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] 📖 [Docs]
- [x] 🪲 [Fix]
- [ ] 🩹 [Patch]
- [ ] ⚠️ [Security fix]
- [ ] 🚀 [Feature]
- [ ] 🌟 [Breaking change]

## Checklist

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
    @MariusStorhaug
    MariusStorhaug authored Sep 5, 2025
    Configuration menu
    Copy the full SHA
    4bf12ff View commit details
    Browse the repository at this point in the history
Loading