🩹 [CI]: Refactor Get-TestSuites workflow to improve output formatting and ensure JSON array structure

MariusStorhaug · MariusStorhaug · commit 04c5556cf869 · 2025-03-14T14:49:12.000+01:00
diff --git a/.github/workflows/Get-TestSuites.yml b/.github/workflows/Get-TestSuites.yml
@@ -74,10 +74,12 @@ jobs:
           WorkingDirectory: ${{ inputs.WorkingDirectory }}
           Script: |
             # Get-TestSuites
-            $skipTests = $env:PSMODULE_GET_TESTSUITES_INPUT_SkipTests -Split ",|\s+" | ForEach-Object { $_.Trim() }
+            $skipTests = $env:PSMODULE_GET_TESTSUITES_INPUT_SkipTests -split '[,\s]+' | ForEach-Object {
+                $_.Trim()
+            }
 
             LogGroup 'Tests to be skipped:' {
-              $skipTests | ForEach-Object { " - $_ " }
+              $skipTests | ForEach-Object { " - $_" }
             }
 
             if ($skipTests -contains 'All') {
@@ -108,15 +110,17 @@ jobs:
                     $sourceCodeTestSuites = $osConfigs
                 }
                 $sourceCodeTestSuites | Format-Table -AutoSize | Out-String
-                Set-GitHubOutput -Name SourceCodeTestSuites -Value ($sourceCodeTestSuites ?? '[]')
+                $sourceCodeTestSuites = $sourceCodeTestSuites | ConvertTo-Json -AsArray
+                Set-GitHubOutput -Name SourceCodeTestSuites -Value $sourceCodeTestSuites
             }
 
             LogGroup 'Module Test Suites:' {
                 if ($skipTests -notcontains 'Module') {
                     $moduleTestSuites = $osConfigs
                 }
                 $moduleTestSuites | Format-Table -AutoSize | Out-String
-                Set-GitHubOutput -Name ModuleTestSuites -Value ($moduleTestSuites ?? '[]')
+                $moduleTestSuites = $moduleTestSuites | ConvertTo-Json -AsArray
+                Set-GitHubOutput -Name ModuleTestSuites -Value $moduleTestSuites
             }
 
             LogGroup 'Module Local Test Suites:' {
@@ -179,5 +183,6 @@ jobs:
                     }
                 }
                 $moduleLocalTestSuites | Format-Table -AutoSize | Out-String
-                Set-GitHubOutput -Name ModuleLocalTestSuites -Value ($moduleLocalTestSuites ?? '[]')
+                $moduleLocalTestSuites = $moduleLocalTestSuites | ConvertTo-Json -AsArray
+                Set-GitHubOutput -Name ModuleLocalTestSuites -Value $moduleLocalTestSuites
             }

Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,12 @@ jobs:`
`74`	`74`	`WorkingDirectory: ${{ inputs.WorkingDirectory }}`
`75`	`75`	`Script: \|`
`76`	`76`	`# Get-TestSuites`
`77`		`- $skipTests = $env:PSMODULE_GET_TESTSUITES_INPUT_SkipTests -Split ",\|\s+" \| ForEach-Object { $_.Trim() }`
	`77`	`+ $skipTests = $env:PSMODULE_GET_TESTSUITES_INPUT_SkipTests -split '[,\s]+' \| ForEach-Object {`
	`78`	`+ $_.Trim()`
	`79`	`+ }`
`78`	`80`
`79`	`81`	`LogGroup 'Tests to be skipped:' {`
`80`		`- $skipTests \| ForEach-Object { " - $_ " }`
	`82`	`+ $skipTests \| ForEach-Object { " - $_" }`
`81`	`83`	`}`
`82`	`84`
`83`	`85`	`if ($skipTests -contains 'All') {`
`@@ -108,15 +110,17 @@ jobs:`
`108`	`110`	`$sourceCodeTestSuites = $osConfigs`
`109`	`111`	`}`
`110`	`112`	`$sourceCodeTestSuites \| Format-Table -AutoSize \| Out-String`
`111`		`- Set-GitHubOutput -Name SourceCodeTestSuites -Value ($sourceCodeTestSuites ?? '[]')`
	`113`	`+ $sourceCodeTestSuites = $sourceCodeTestSuites \| ConvertTo-Json -AsArray`
	`114`	`+ Set-GitHubOutput -Name SourceCodeTestSuites -Value $sourceCodeTestSuites`
`112`	`115`	`}`
`113`	`116`
`114`	`117`	`LogGroup 'Module Test Suites:' {`
`115`	`118`	`if ($skipTests -notcontains 'Module') {`
`116`	`119`	`$moduleTestSuites = $osConfigs`
`117`	`120`	`}`
`118`	`121`	`$moduleTestSuites \| Format-Table -AutoSize \| Out-String`
`119`		`- Set-GitHubOutput -Name ModuleTestSuites -Value ($moduleTestSuites ?? '[]')`
	`122`	`+ $moduleTestSuites = $moduleTestSuites \| ConvertTo-Json -AsArray`
	`123`	`+ Set-GitHubOutput -Name ModuleTestSuites -Value $moduleTestSuites`
`120`	`124`	`}`
`121`	`125`
`122`	`126`	`LogGroup 'Module Local Test Suites:' {`
`@@ -179,5 +183,6 @@ jobs:`
`179`	`183`	`}`
`180`	`184`	`}`
`181`	`185`	`$moduleLocalTestSuites \| Format-Table -AutoSize \| Out-String`
`182`		`- Set-GitHubOutput -Name ModuleLocalTestSuites -Value ($moduleLocalTestSuites ?? '[]')`
	`186`	`+ $moduleLocalTestSuites = $moduleLocalTestSuites \| ConvertTo-Json -AsArray`
	`187`	`+ Set-GitHubOutput -Name ModuleLocalTestSuites -Value $moduleLocalTestSuites`
`183`	`188`	`}`