🔧 [CI]: Refactor conditional logic for name assignment in Get-Settings.yml for improved readability

MariusStorhaug · MariusStorhaug · commit 17b3d0777f29 · 2025-03-31T16:25:25.000+02:00
diff --git a/.github/workflows/Get-Settings.yml b/.github/workflows/Get-Settings.yml
@@ -131,7 +131,7 @@ jobs:
                     RepositoryName = $env:GITHUB_REPOSITORY_NAME
                 } | Format-List | Out-String
 
-                $name = ![string]::IsNullOrEmpty($inputName) ? $name : [string]::IsNullOrEmpty($settings.Name) ? $settings.Name : $env:GITHUB_REPOSITORY_NAME
+                $name = ![string]::IsNullOrEmpty($inputName) ? $name : ![string]::IsNullOrEmpty($settings.Name) ? $settings.Name : $env:GITHUB_REPOSITORY_NAME
             }
 
             $settings = [pscustomobject]@{

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ jobs:`
`131`	`131`	`RepositoryName = $env:GITHUB_REPOSITORY_NAME`
`132`	`132`	`} \| Format-List \| Out-String`
`133`	`133`
`134`		`- $name = ![string]::IsNullOrEmpty($inputName) ? $name : [string]::IsNullOrEmpty($settings.Name) ? $settings.Name : $env:GITHUB_REPOSITORY_NAME`
	`134`	`+ $name = ![string]::IsNullOrEmpty($inputName) ? $name : ![string]::IsNullOrEmpty($settings.Name) ? $settings.Name : $env:GITHUB_REPOSITORY_NAME`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`$settings = [pscustomobject]@{`